Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Create labels when repo is added to installation #15

Merged
merged 8 commits into from
Dec 21, 2018
Merged

Conversation

rabaut
Copy link

@rabaut rabaut commented Dec 20, 2018

Was only able to test that this will make the proper createLabel request to the repo using probot event simulation

Resolves #9

@rabaut rabaut requested a review from mfix22 December 20, 2018 22:41
Copy link
Collaborator

@mfix22 mfix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM 👍Just want to confirm the create label if it already exists issue before merging

Copy link
Collaborator

@mfix22 mfix22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to subscribe to installation.created and handle it almost the same as installation_repositories_added, except using repositories instead of repositories_added

@mfix22 mfix22 merged commit c3a982a into master Dec 21, 2018
@mfix22 mfix22 deleted the installation branch December 21, 2018 20:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants