feat(logstore): handle paused stream #20511
Merged
+22
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
9c3f223 to
aa35e12
Compare
8 tasks
wenym1
reviewed
Feb 20, 2025
| @@ -430,6 +451,9 @@ impl<S: StateStoreRead> ReadFuture<S> { | |||
| *self = ReadFuture::Idle; | |||
| } | |||
| ReadFuture::ReadingFlushedChunk { .. } | ReadFuture::Idle => {} | |||
| ReadFuture::Paused => { | |||
| unreachable!("should not be polled after paused") | |||
There was a problem hiding this comment.
Can just move the return pending().await at the beginning to here to avoid an extra match.
| @@ -260,6 +260,7 @@ impl<S: StateStore> SyncedKvLogStoreExecutor<S> { | |||
| new_log_store_state(self.table_id, local_state_store, self.serde); | |||
| initial_write_state.init(first_write_epoch).await?; | |||
|
|
|||
| let mut pause_stream = false; | |||
There was a problem hiding this comment.
May set the initial value as barrier.is_pause_on_startup()
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
aa35e12 to
78b0623
Compare
wenym1
reviewed
Feb 25, 2025
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
78b0623 to
78df558
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
3 times, most recently
from
80359d9 to
52d2229
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
52d2229 to
d318c81
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Standing-Man
pushed a commit
to Standing-Man/risingwave
that referenced
this pull request
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note