refactor(stream): shortcircuit flushing chunks on barrier #20523
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
kwannoel
changed the title
wenym1
reviewed
Feb 20, 2025
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
aa35e12 to
78b0623
Compare
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
593e344 to
fffaf55
Compare
wenym1
reviewed
Feb 25, 2025
| writer.write_chunk(chunk, *epoch, *start_seq_id, *end_seq_id)?; | ||
| *flushed = true; | ||
| if barrier.is_checkpoint() { | ||
| for (epoch, item) in &mut buffer.buffer { |
There was a problem hiding this comment.
It seems that when we add items to buffer, we use buffer.push_back(...), which means a newer item is at the back. Therefore, should we iterate from back to front instead?
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
637427a to
a3e8c86
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
78b0623 to
78df558
Compare
wenym1
approved these changes
Feb 26, 2025
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
78df558 to
e6c6017
Compare
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
a3e8c86 to
099c0fc
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
e6c6017 to
80359d9
Compare
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
d17eae3 to
494bafc
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
80359d9 to
52d2229
Compare
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
494bafc to
f582b85
Compare
kwannoel
force-pushed
the
kwannoel/handle-pause
branch
from
52d2229 to
d318c81
Compare
kwannoel
force-pushed
the
kwannoel/sync-improve
branch
from
f582b85 to
d2f28f0
Compare
Standing-Man
pushed a commit
to Standing-Man/risingwave
that referenced
this pull request
Feb 28, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
No need to iterate through the rest of the buffer after hitting a flushed item / chunk. Because the rest of the chunks should already be flushed
Checklist
Documentation
Release note