Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable support for rails 7.1 #77

Closed
wants to merge 4 commits into from
Closed

Enable support for rails 7.1 #77

wants to merge 4 commits into from

Conversation

kevinrobayna
Copy link
Contributor

@kevinrobayna
Copy link
Contributor Author

I have a feeling the build in master are broken since it's failing to run 6.1

@igor-alexandrov
Copy link
Contributor

igor-alexandrov commented Oct 6, 2023

To add support for Rails 7.1 we probably should drop support for < 6.1.

  • pg_party uses very old version of rspec-rails and rspec-mocks, AR 7.1 added .with method, which broke old versions of RSpec. Read more here: Rails 7.1 breaks receive().with rspec/rspec-mocks#1530
  • Also database_cleaner < 2.0 will not work with AR 7.1 and if we will continue to support on AR >= 6.1 than it is not needed at all, because we can use ActiveRecord::Tasks::DatabaseTasks.truncate_all.

Let me know what do you think.

@rkrage
Copy link
Owner

rkrage commented Oct 6, 2023

Thanks for getting this going. It seems like there's a bit more work to do, so I'm gonna start working in a separate branch (I'll add both of you as coauthors on the commit)

@igor-alexandrov
Copy link
Contributor

@rkrage I almost done everything in #78. One test fails with AR 7.1 and I cannot really understand why... Please take a look.

@igor-alexandrov
Copy link
Contributor

@rkrage by the way, what do you think about moving from Circle to GitHub Actions?

@rkrage
Copy link
Owner

rkrage commented Oct 6, 2023

Alright, I have this PR that combines both of your work with some additional cleanup: #79

@rkrage
Copy link
Owner

rkrage commented Oct 6, 2023

what do you think about moving from Circle to GitHub Actions?

I'm not opposed, but I'm not sure if I have the time to work on that. This project is basically in maintenance mode right now. I don't plan to add any new features

@igor-alexandrov
Copy link
Contributor

what do you think about moving from Circle to GitHub Actions?

I'm not opposed, but I'm not sure if I have the time to work on that. This project is basically in maintenance mode right now. I don't plan to add any new features

I will try to do this.

@rkrage
Copy link
Owner

rkrage commented Oct 6, 2023

Closing in favor of #79

@rkrage rkrage closed this Oct 6, 2023
@igor-alexandrov
Copy link
Contributor

@kevinrobayna please close this one in favour of #79

@kevinrobayna kevinrobayna deleted the patch-1 branch October 7, 2023 13:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants