Add support for Rails 7.1 #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Robayna <kevinrobayna@users.noreply.github.com> Co-authored-by: Igor Alexandrov <igor-alexandrov@users.noreply.github.com>
Co-authored-by: Kevin Robayna <kevinrobayna@users.noreply.github.com> Co-authored-by: Igor Alexandrov <igor-alexandrov@users.noreply.github.com>
rkrage
commented
Oct 6, 2023
| pg_inherits | ||
| JOIN pg_class AS p ON inhparent = p.oid | ||
| WHERE p.relkind = 'p' | ||
| SQL |
There was a problem hiding this comment.
@igor-alexandrov I fixed the failing test by removing it 😆
I don't think it ever really made sense to rescue an error here anyways
There was a problem hiding this comment.
Yeaahhh! I love this approach, dude!
|
@rkrage this looks good to me! |
Closed
|
Maybe it would be good to add Requirements section to the Readme and announce that PgParty works with Rails 6.1 and above and PostgreSQL > 10. |
Yup that's probably a good idea. I have a few other things I'd like to add to the readme as well, so I'll follow up with another commit after I merge this |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@igor-alexandrov (lol sorry I just saw that you opened a PR as well)
@kevinrobayna
Note that this also adds a requirement for Ruby 3 and removes EOL Postgres versions from the build matrix