Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Clarified paragraph regarding access to blocked zones #2

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

thomerz
Copy link

@thomerz thomerz commented Aug 13, 2018

Added a sentence that clarifies that blocked zones of any machines must be reachable from any location on the field.

@thomerz thomerz requested a review from a team as a code owner August 13, 2018 11:10
morxa
morxa previously approved these changes Aug 23, 2018
@morxa morxa requested a review from a team August 23, 2018 11:58
MostafaGomaa
MostafaGomaa previously approved these changes Sep 4, 2018
@morxa morxa requested review from teamsolidus and vcoelen October 14, 2018 11:10
@morxa morxa dismissed stale reviews from MostafaGomaa and themself via 856f3dc January 15, 2019 15:41
@morxa morxa force-pushed the field-generation-no-unreachable branch from 96adee9 to 856f3dc Compare January 15, 2019 15:41
@thomerz thomerz requested review from dka14 and timn as code owners January 15, 2019 15:41
@morxa
Copy link
Member

morxa commented Jan 15, 2019

I rebased onto the latest master and fixed some issues found by the linter.

@morxa
Copy link
Member

morxa commented Jan 15, 2019

+1

1 similar comment
@timn
Copy link
Member

timn commented Jan 16, 2019

+1

Copy link
Member

@timn timn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text looks good to me. I get the idea what is meant.

@vcoelen
Copy link

vcoelen commented Jan 16, 2019

+1

2 similar comments
@MostafaGomaa
Copy link
Member

+1

@teamsolidus
Copy link
Contributor

+1

@timn
Copy link
Member

timn commented Jan 22, 2019

Why did you close this when this was not merged, yet?

@timn timn reopened this Jan 22, 2019
@teamsolidus
Copy link
Contributor

+1

@morxa
Copy link
Member

morxa commented Jan 30, 2019

Proposal accepted

  • in favor: 3
  • abstentions: 0
  • opposed: 0

@morxa morxa merged commit bdf952d into master Jan 30, 2019
@morxa morxa deleted the field-generation-no-unreachable branch January 30, 2019 10:16
@morxa morxa added accepted-rule-change The rule change has been accepted and removed vote-in-progress labels Feb 14, 2019
@morxa morxa added this to the RoboCup 2019 milestone Feb 14, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
accepted-rule-change The rule change has been accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants