Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed iCub3 models #243

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Removed iCub3 models #243

merged 1 commit into from
Nov 29, 2024

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene requested a review from traversaro November 20, 2024 10:07
@Nicogene Nicogene self-assigned this Nov 20, 2024
@pattacini pattacini changed the title Reoved iCub3 models Removed iCub3 models Nov 25, 2024
@traversaro
Copy link
Member

I am not sure if this had to be merged before or after robotology/icub-models-generator#281, however I guess we need to have it point to devel as the model will be pushed there (I also need to push master to devel).

@Nicogene
Copy link
Member Author

I am not sure if this had to be merged before or after robotology/icub-models-generator#281, however I guess we need to have it point to devel as the model will be pushed there (I also need to push master to devel).

I change the target branch to devel then?

@traversaro traversaro changed the base branch from master to devel November 28, 2024 14:21
@traversaro
Copy link
Member

I am not sure if this had to be merged before or after robotology/icub-models-generator#281, however I guess we need to have it point to devel as the model will be pushed there (I also need to push master to devel).

I change the target branch to devel then?

I tried and it seems to be working fine.

@traversaro traversaro closed this Nov 28, 2024
@traversaro traversaro reopened this Nov 28, 2024
@Nicogene Nicogene marked this pull request as ready for review November 28, 2024 14:24
@traversaro traversaro merged commit 5cc1898 into devel Nov 29, 2024
63 checks passed
@traversaro traversaro deleted the feat/removeICub3 branch November 29, 2024 08:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants