[CI] Remove Debug builds on Ubuntu 18.04, macOS and Windows #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
requested review from
diegoferigo,
Nicogene,
lrapetti,
yeshasvitirupachuri,
kouroshD and
gabrielenava
|
Friendly ping @diegoferigo . |
|
Woops sorry, I missed this notification somehow. LGTM. |
diegoferigo
approved these changes
May 3, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we recently have added in our GitHub Actions script:
the number of jobs has grown a lot. To decrease the number of jobs, I think it is safe to remove the Debug jobs for Ubuntu 18.04, macOS and Windows. The amount of failures that affect only Debug jobs and not Release jobs is quite limited (typically just some code that was not updated in a
ifndef NDEBUGor in anassert), and we still use the Debug build mode in Docker builds.