Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

cxx-standard should not be in CMAKE_CXX_FLAGS #6384

Closed
misho104 opened this issue Sep 18, 2020 · 0 comments · Fixed by #6466
Closed

cxx-standard should not be in CMAKE_CXX_FLAGS #6384

misho104 opened this issue Sep 18, 2020 · 0 comments · Fixed by #6466
Assignees
@bellenot @SpectreVert
Labels
bug in:Build System

Comments

@misho104
Copy link

Describe the bug

CMAKE_CXX_FLAGS, set by hand in ROOTUseFile.cmake, includes a specification on cxx standard, which should be specified rather by CMAKE_CXX_STANDARD variable.

In a projects using ROOT, the inclusion causes doubly-specified cxx-standard in their compile procedure, and the maintainer transferred me here; see the thread here:

iLCSoft/LCIO#109 (comment)

Expected behavior

--std= options should be set in CMAKE_CXX_STANDARD, rather than CMAKE_CXX_FLAGS.

To Reproduce

see iLCSoft/LCIO#109 (comment)

Setup

ROOT Docker images: docker pull rootproject/root:6.22.02-ubuntu20.04, ran on docker on WSL2.
@misho104 misho104 added the bug label Sep 18, 2020
@misho104 misho104 mentioned this issue Sep 18, 2020
Closed
@oshadura oshadura mentioned this issue Sep 25, 2020
Merged
@SpectreVert SpectreVert self-assigned this May 11, 2021
@oshadura oshadura assigned bellenot and unassigned oshadura Jul 14, 2021
guitargeek added a commit that referenced this issue Jan 16, 2024
@oshadura @guitargeek
[cmake] Set CMAKE_CXX_STANDARD explicitly in RootUseFile.cmake
d487a42 
Closes #6384,
---------

Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
vgvassilev pushed a commit to vgvassilev/root that referenced this issue Feb 8, 2024
@oshadura @guitargeek @vgvassilev
[cmake] Set CMAKE_CXX_STANDARD explicitly in RootUseFile.cmake
ac45ba0 
Closes root-project#6384,
---------

Co-authored-by: Jonas Rembser <jonas.rembser@cern.ch>
@guitargeek guitargeek mentioned this issue Apr 17, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@bellenot bellenot

@SpectreVert SpectreVert

Labels
bug in:Build System
Projects
None yet
Milestone
No milestone
5 participants
@misho104 @bellenot @guitargeek @oshadura @SpectreVert