[cmake] Add back cxx_std_ compile feature
#15254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially revert commit d487a42 ("[cmake] Set CMAKE_CXX_STANDARD explicitly in RootUseFile.cmake") because this is required to propagate the C++ standard via CMake library targets, as advertised on the website. Fixes root-project#15253
hahnjo
added
in:Build System
clean build
Test Results 12 files 12 suites 2d 6h 5m 41s ⏱️ Results for commit 80cdfa2. |
guitargeek
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
LGTM! As long as we are not regressing to putting the standard in the CMAKE_CXX_FLAGS ( see #6384), any part of the linked commit can be reverted.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert commit d487a42 ("[cmake] Set CMAKE_CXX_STANDARD explicitly in RootUseFile.cmake") because this is required to propagate the C++ standard via CMake library targets, as advertised on the website.
Fixes #15253 (needs to be backported to
v6-32-00-patches)