Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rodev #176

Merged
merged 3 commits into from
Jun 13, 2019
Merged

Rodev #176

merged 3 commits into from
Jun 13, 2019

Conversation

maelle
Copy link
Member

@maelle maelle commented Jun 12, 2019

cf #48

@maelle maelle requested review from sckott and annakrystalli June 12, 2019 13:21
Copy link
Contributor

@annakrystalli annakrystalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All LGTM! rodev is looking so slick 😎!

@maelle maelle added this to the 0.3.0 milestone Jun 13, 2019
@maelle maelle merged commit d9578fc into dev Jun 13, 2019
sckott pushed a commit that referenced this pull request Oct 4, 2019
* update dev (#157)

* draft book release guidance (#152)

* include the book release guidance in the book

* update news

* clarify release guidance

* Remove "click here" link (#166)

* Update all links to HTTPS (#167)

* URLs should be enclosed in angle brackets, e.g. <https://www.r-project.org> (#169)

--https://cran.r-project.org/doc/manuals/r-release/R-exts.html

* Expand on what 'more discoverable' means (#172)

* fix @melvidoni's affiliation in dev too

* new dev guide URL

* add mention of usethis functions for adding testing or vignette infrastructure in the part about dependencies in the package building guide thx @cboettig fix #112

* remove recommendation about `roxygen2` dev version since the latest stable version has what is needed. fix #165 thanks @Bisaloo

* add more details about gitflow

* more direct link to Amanda's write-up

* update ref to R pkg book

* fix #163 now that the book is less new

* Update pkg_building.Rmd (#178)

* Update pkg_building.Rmd

See #151

* Update appendix.Rmd

As requested.

* Update index.Rmd

As requested.

* Rodev mentions (#176)

Fix #48

* CRAN checks explanations (#177)

* Explain CRAN checks

* add that rOpenSci maintains API

Fix #175

* docs.ropensci.org guidance (#162)

fix #164 and cf #155

* fix #155 by improving pkgdown guidance

* suggest R Markdown hunks approach for README and vignette (#161)

* fix #179 by fixing formatting of Appendices B-D in the pdf version of the book

* make NEWs template look ok again cf #179

* fix ref to R packages book

* add link to rOpenSci community call "Security for R" to security chapter cf #154

* Add note about pkgreviewr Rstudio dependency. 

Resolves #183

* Break up reproducibility category into component parts (#184)

- Also increase clarity that software wrappers are for non-R programs
- Re-arrange thematically
- Add appropriate examples

Closes ropensci/software-review-meta#81

* fix #192 update instructions in readme for rendering book locally, _book instead of _output
and updated NEWS

* fix spelling and missing "an" in Code Style subsection within Packaging Guide section (#182)

* fix #193 change slack channel name to software-review from onboarding in editor checklist
add entry to news

* #128 taking over maint. chapter work, moved to new branch

* move taking over to chapter 10

* spelling changs in taking over chapter

* add news item for the taking over chapter #128

* Update JOSS instrucctions

* Explicitly use RO repo url in JOSS submittal.

* fix #180 add note for handling editors to nominate blog posts of interest

* fix some links in the changelog

* Fix #181 typo

* fix #191 add to approval template mention of including docs.ropensci.org link in DESCRIPTION file

* fix section link to docsropensci in pkg building chapter, was missing pound sign

* fix some broken urls in pkg_building

* fix spelling problems after using spelling
@maelle maelle deleted the rodev branch October 31, 2019 10:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants