Break up reproducibility category into component parts #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamross
requested review from
karthik,
lmullen,
sckott,
annakrystalli,
geanders and
melvidoni
noamross
force-pushed
the
revise-scope-cats
branch
from
6222364 to
565b940
Compare
- Also increase clarity that software wrappers are for non-R programs - Re-arrange thematically
noamross
force-pushed
the
revise-scope-cats
branch
from
565b940 to
c3fa441
Compare
sckott
reviewed
Jul 22, 2019
There was a problem hiding this comment.
looks good overall.
These two are not completely on topic maybe:
- maybe we can use a different example in geospatial area, because
rgeospatialqualityhas been abandoned https://github.com/ropenscilabs/rgeospatialquality - text analysis: can we include an example here?
|
The thematic rearrangements looks good to me. |
|
I really like these new changes! |
annakrystalli
approved these changes
Jul 23, 2019
sckott
pushed a commit
that referenced
this pull request
Oct 4, 2019
* update dev (#157) * draft book release guidance (#152) * include the book release guidance in the book * update news * clarify release guidance * Remove "click here" link (#166) * Update all links to HTTPS (#167) * URLs should be enclosed in angle brackets, e.g. <https://www.r-project.org> (#169) --https://cran.r-project.org/doc/manuals/r-release/R-exts.html * Expand on what 'more discoverable' means (#172) * fix @melvidoni's affiliation in dev too * new dev guide URL * add mention of usethis functions for adding testing or vignette infrastructure in the part about dependencies in the package building guide thx @cboettig fix #112 * remove recommendation about `roxygen2` dev version since the latest stable version has what is needed. fix #165 thanks @Bisaloo * add more details about gitflow * more direct link to Amanda's write-up * update ref to R pkg book * fix #163 now that the book is less new * Update pkg_building.Rmd (#178) * Update pkg_building.Rmd See #151 * Update appendix.Rmd As requested. * Update index.Rmd As requested. * Rodev mentions (#176) Fix #48 * CRAN checks explanations (#177) * Explain CRAN checks * add that rOpenSci maintains API Fix #175 * docs.ropensci.org guidance (#162) fix #164 and cf #155 * fix #155 by improving pkgdown guidance * suggest R Markdown hunks approach for README and vignette (#161) * fix #179 by fixing formatting of Appendices B-D in the pdf version of the book * make NEWs template look ok again cf #179 * fix ref to R packages book * add link to rOpenSci community call "Security for R" to security chapter cf #154 * Add note about pkgreviewr Rstudio dependency. Resolves #183 * Break up reproducibility category into component parts (#184) - Also increase clarity that software wrappers are for non-R programs - Re-arrange thematically - Add appropriate examples Closes ropensci/software-review-meta#81 * fix #192 update instructions in readme for rendering book locally, _book instead of _output and updated NEWS * fix spelling and missing "an" in Code Style subsection within Packaging Guide section (#182) * fix #193 change slack channel name to software-review from onboarding in editor checklist add entry to news * #128 taking over maint. chapter work, moved to new branch * move taking over to chapter 10 * spelling changs in taking over chapter * add news item for the taking over chapter #128 * Update JOSS instrucctions * Explicitly use RO repo url in JOSS submittal. * fix #180 add note for handling editors to nominate blog posts of interest * fix some links in the changelog * Fix #181 typo * fix #191 add to approval template mention of including docs.ropensci.org link in DESCRIPTION file * fix section link to docsropensci in pkg building chapter, was missing pound sign * fix some broken urls in pkg_building * fix spelling problems after using spelling
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ropensci/software-review-meta#81