Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[FEATURE] Split get-osmdata.R into several files #304

Closed
mpadge opened this issue Jan 30, 2023 · 1 comment · Fixed by #306
Closed

[FEATURE] Split get-osmdata.R into several files #304

mpadge opened this issue Jan 30, 2023 · 1 comment · Fixed by #306
Assignees

Comments

@mpadge
Copy link
Member

mpadge commented Jan 30, 2023

@jmaspons Once we've merged your current PRs (#299, #302, #303), the get-osmdata.R file should be split into several smaller files. I suggest:

  • get-osmdata.R (with only the minor helper functions)
  • get-osmdata-sf.R
  • get-osmdata-sp.R
  • get-osmdata-sp.R
  • get-osmdata-df.R
  • get-osmdata-meta.R

But we can see what works best once we get that far. You may assign yourself here if you're keen to do that, otherwise I'll happily do it, and ask you to review.

@jmaspons
Copy link
Collaborator

jmaspons commented Feb 1, 2023

Ok! I'll try after #299 is merged, which is ready. I can't assign myself for the task. Can you add me, @mpadge ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants