Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update docs and dependencies #302

Merged
merged 7 commits into from
Jan 31, 2023
Merged

Update docs and dependencies #302

merged 7 commits into from
Jan 31, 2023

Conversation

jmaspons
Copy link
Collaborator

Added missing osmdata_* functions, silicate as a suggested dependency and sp moved from imported to suggested

DESCRIPTION Outdated Show resolved Hide resolved
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, moving sp to Suggests - which is a really great idea!! - then needs each function which actually uses it to first have:

requireNamespace ("sp")

Those 2 functions are

osm_elevation <- function (dat, elev_file) {

and
trim_osmdata_sfp <- function (dat, bb_poly, exclude = TRUE) {

The latter has an example of how it'd done here - initial lines at the very start of the function. Thanks

@mpadge
Copy link
Member

mpadge commented Jan 27, 2023

@jmaspons Once you address the above, i'll happily approve and merge. I also wanted to arrange a video chat with you, mostly so that i can express my gratitude for all of your work. I don't have contact details for you, so can you please either email me, or you should be able to book a meeting at cal.com / markpadgham. Thanks.

jmaspons and others added 2 commits January 27, 2023 16:22
@jmaspons
Copy link
Collaborator Author

Hopfully solved! I'll contact you, @mpadge . Let's find some day for next week

R/elevation.R Outdated Show resolved Hide resolved
R/elevation.R Outdated Show resolved Hide resolved
R/trim-osmdata.R Outdated Show resolved Hide resolved
@jmaspons
Copy link
Collaborator Author

==> Rcpp::compileAttributes()

* Updated R/RcppExports.R
Warning message:
The following packages are referenced using Rcpp::depends attributes however are not listed in the Depends, Imports or LinkingTo fields of the package DESCRIPTION file: sp 

Perhaps it requires some more work to move sp to suggested packages

@mpadge
Copy link
Member

mpadge commented Jan 31, 2023

Sorry, that's my fault. Just need to delete this line:

// [[Rcpp::depends(sp)]]

That was just there for some historical reason I can no longer remember, but is no longer needed.

@mpadge
Copy link
Member

mpadge commented Jan 31, 2023

Thanks @jmaspons. One more thing that generally needs to be done is to update the NEWS file. I'll merge for now and do that straight away, but we should both try to remember to always update NEWS with each PR 😀

@mpadge mpadge merged commit 0955671 into ropensci:main Jan 31, 2023
mpadge added a commit that referenced this pull request Jan 31, 2023
@jmaspons jmaspons deleted the docs_and_deps branch February 2, 2023 10:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants