Allow to chain add_osm_feature/s function calls #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the patch: * add_osm_feature collapse features from add_osm_features if called first * if add_osm_feature is called first, features get eliminated after calling add_osm_features After: * add_osm_feature add features to each item from opq$features * add_osm_features add features to the opq$features vector with new items Bonus: features parameter now is parsed using paste_features which allow to pass more than one value for each list item # Conflicts: # R/opq.R
Useful if the code is reran
|
Ready for review @mpadge |
|
All green now, @mpadge |
|
Great, thanks @jmaspons 😀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make add_osm_feature(s) do the proper AND and OR additions to the osm feature filters
Before the patch:
After:
Bonus: features parameter now is parsed using paste_features which allow
to pass more than one value for each list item