[RQT-JTC] Find limits only in jtc joints | add robot_description combo #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#492) (ros-controls#496) (cherry picked from commit 3829d33) Co-authored-by: Denis Štogl <denis@stoglrobotics.de>
) (cherry picked from commit f6c4769) Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
(cherry picked from commit acaf918) Co-authored-by: Jakub Delicat <109142865+delihus@users.noreply.github.com>
This commit fixes the segfault which happens when the JTC is unloaded, if it is in inactive state but was never activated. (cherry picked from commit 6369faa) Co-authored-by: Márk Szitanics <szitanics@gmail.com>
Co-authored-by: Michael Wiznitzer <michael.wiznitzer@resquared.com> (cherry picked from commit 3a1402e) Co-authored-by: Michael Wiznitzer <31753650+mechwiz@users.noreply.github.com>
Co-authored-by: Solomon Wiznitzer <solomon.wiznitzer@resquared.com> (cherry picked from commit 7cc3434) Co-authored-by: Solomon Wiznitzer <31753673+swiz23@users.noreply.github.com>
…espace (ros-controls#522) Co-authored-by: Tim Verbelen <tim.verbelen@verses.io>
…ols#530) * Use RT buffer for gripper action controller's goal handle * fix format --------- Co-authored-by: Erik Holum <erik.holum@picknik.ai>
(cherry picked from commit 42f6c14) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…-controls#543) * Add pid gain structure to documentation * Remove trailing whitespace * Remove trailing colons (cherry picked from commit e0a373a) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
…os-controls#563) (cherry picked from commit 1508d45) Co-authored-by: Dr. Denis <denis@stoglrobotics.de>
…er.yaml (ros-controls#570) (ros-controls#576) (cherry picked from commit 467bc4a) Co-authored-by: muritane <31107191+muritane@users.noreply.github.com>
…ntrols#491) (ros-controls#579) * Use the same variables for state feedback and PID loop * Make joint_error normalization configurable * Activate test for only velocity controller * Allow ff_velocity_scale=0 without deprecated warning * Add test for setpoint due to normalized position error * Update comments in test Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> (cherry picked from commit 67e5d4d) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit 28cb552) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 5a28a2a) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) (ros-controls#1033) (cherry picked from commit e0491ba) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit d51306a) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ols#1121) * Add file type filters * Add jazzy workflows and readme * Check docs on correct branch * Specify workflow names * Run auto-update only once per month * Update upstream pre-commit wf --------- Co-authored-by: Felix Exner (fexner) <felix_mauch@web.de> (cherry picked from commit 4ae8daf) # Conflicts: # .github/workflows/iron-abi-compatibility.yml # .github/workflows/rolling-check-docs.yml Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Signed-off-by: Jakub Delicat <jakub.delicat@husarion.com>
github-actions
bot
requested review from
arne48,
bmagyar,
christophfroehlich,
destogl,
olivier-stasse,
progtologist and
saikishor
|
@delihus, all pull requests must be targeted towards the |
|
This pull request is in conflict. Could you fix it @delihus? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there are joints what don't have implemented limits rqt-jtc throws a lot of errors.
I added looking for limits for joints what are controlled by actual JTC.
The main feature is that it is possible to change robot description topic to control specific robot. Unfortunately it is not possible to do this using namespace in my case. My namespace issue: ros-controls/ros2_control#1506
Result video:
Screencast from 10.05.2024 11:12:31.webm