Drop some over-agressive asserts from test_rosdep_main #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These asserts check that nothing was written to stderr during some top-level rosdep invocations. On derivative platforms like CentOS and AlmaLinux, a message is written to stderr during normal operation stating that the platform is an alias to the parent platform (RHEL, in this example). This is normal and expected behavior on those platforms, so the tests should still pass there.
clalancette
approved these changes
Jun 24, 2022
russkel
pushed a commit
to Greenroom-Robotics/rosdep
that referenced
this pull request
Jun 27, 2022
…cture#888) These asserts check that nothing was written to stderr during some top-level rosdep invocations. On derivative platforms like CentOS and AlmaLinux, a message is written to stderr during normal operation stating that the platform is an alias to the parent platform (RHEL, in this example). This is normal and expected behavior on those platforms, so the tests should still pass there.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These asserts check that nothing was written to stderr during some top-level rosdep invocations. On derivative platforms like CentOS and AlmaLinux, a message is written to stderr during normal operation stating that the platform is an alias to the parent platform (RHEL, in this example). This is normal and expected behavior on those platforms, so the tests should still pass there.