Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drop some over-agressive asserts from test_rosdep_main #888

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Drop some over-agressive asserts from test_rosdep_main #888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions test/test_rosdep_main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,15 +135,13 @@ def test_check(self):

stdout, stderr = b
assert stdout.getvalue().strip() == 'All system dependencies have been satisfied', stdout.getvalue()
assert not stderr.getvalue(), stderr.getvalue()
try:
osd = rospkg.os_detect.OsDetect()
override = '%s:%s' % (osd.get_name(), osd.get_codename())
with fakeout() as b:
rosdep_main(['check', 'python_dep', '--os', override] + cmd_extras)
stdout, stderr = b
assert stdout.getvalue().strip() == 'All system dependencies have been satisfied'
assert not stderr.getvalue(), stderr.getvalue()
except SystemExit:
assert False, 'system exit occurred'

Expand All @@ -153,7 +151,6 @@ def test_check(self):
rosdep_main(['check', 'packageless'] + cmd_extras)
stdout, stderr = b
assert stdout.getvalue().strip() == 'All system dependencies have been satisfied'
assert not stderr.getvalue(), stderr.getvalue()
except SystemExit:
assert False, 'system exit occurred'

Expand Down Expand Up @@ -190,12 +187,10 @@ def read_stdout(cmd, capture_stderr=False):
rosdep_main(['install', 'python_dep'] + cmd_extras)
stdout, stderr = b
assert 'All required rosdeps installed' in stdout.getvalue(), stdout.getvalue()
assert not stderr.getvalue(), stderr.getvalue()
with fakeout() as b:
rosdep_main(['install', 'python_dep', '-r'] + cmd_extras)
stdout, stderr = b
assert 'All required rosdeps installed' in stdout.getvalue(), stdout.getvalue()
assert not stderr.getvalue(), stderr.getvalue()
with fakeout() as b:
rosdep_main([
'install', '-s', '-i',
Expand All @@ -216,7 +211,6 @@ def read_stdout(cmd, capture_stderr=False):
]
lines = stdout.getvalue().splitlines()
assert set(lines) == set(expected), lines
assert not stderr.getvalue(), stderr.getvalue()
except SystemExit:
assert False, 'system exit occurred: ' + b[1].getvalue()
try:
Expand Down