Add note in ExecuteKnownTrajectory service to recommend ExecuteTrajectory action.

[130s]

Not entirely sure if this suggestion is the right move, but looking at places like this comment we want to switch to the new action.

[130s]

Apparently I was wrong; We still want both moveit/moveit#60 (comment)

So instead of removing, I added a notice in ExecuteKnownTrajectory service to recommend the newly added action.

[v4hn]

-1
Yes, we wanted to retain the obsolete service, until lunar I believe, to be backward compatible.
But even if you add the comment, this would change the checksum of the action specification and is not compatible. ROS compares the checksums of publishers and subscribers before allowing a connection.

[rhaschke]

Closing, due to @v4hn's comment. Deprecation message is included in the main code.

[130s]

Good point for the checksum change. I'm just not sure if updating ONLY comment would change the md5sum, so I asked a question for confirmation (I included there a quick test result I locally did that didn't change checksum).

[130s]

There seems to be a wiki page that says comment are excluded for md5 generation.

As a non-expert MoveIt! coder, the description in msg/srv/action files is very helpful. There's also an open issue #2 for in-file description enhancement.

So reopening.

[v4hn]

Thanks for researching this! Looks like it was a myth - or maybe they changed it at some point?
In this case your addition totally makes sense.

I would prefer to formulate the comment a bit more strict. How about

This service is deprecated and will go away at some point. For new development use the ExecuteTrajectory action.

?

[130s]

Ok, commit updated.

[v4hn]

+1 Looks good to me.

[130s]

Cherrypicked to jade-devel 40b691e