Add fields to store planning time in pick-and-place #43
Conversation
|
This will break ABI in a difficult way for Kinetic. I believe this should be merged into ROS-M, which we haven't branched for yet. We are having a maintainer meeting on March 20th and will be discussing branching. Would you like to join this discussion? |
|
It makes sense to me to put this off until ROS-M. |
|
I agree, we should not merge this into kinetic. |
|
@aochiai please email me so I can invite you. |
davetcoleman
force-pushed
the
melodic-devel
branch
from
9c0ef4b to
343a726
Compare
|
@aochiai I have created the new branch |
| @@ -65,6 +65,8 @@ string[] trajectory_descriptions | |||
| # The performed grasp, if attempt was successful | |||
| Grasp grasp | |||
|
|
|||
| # The amount of time in seconds it took to complete the plan | |||
There was a problem hiding this comment.
This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"
| @@ -56,6 +56,8 @@ string[] trajectory_descriptions | |||
| # The successful place location, if any | |||
| PlaceLocation place_location | |||
|
|
|||
| # The amount of time in seconds it took to complete the plan | |||
There was a problem hiding this comment.
This seems ambiguous. Is it the time to plan or the time to execute the plan? Maybe reword to "it took to generate a plan"
|
@aochiai Can you rewrite the comment to make it less ambiguous in another PR? |
Add new fields to store planning time of the pick-and-place capability.
MoveGroup.actionalready has this.