Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Temporarily work around apt error with grub-efi-amd64-signed #543

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

lhstrh
Copy link
Contributor

@lhstrh lhstrh commented Feb 25, 2023

This action is currently broken. It gets stuck with this error:

Invoking "sudo apt-get upgrade -y"
  /usr/bin/sudo apt-get upgrade -y
  Reading package lists...
  Building dependency tree...
  Reading state information...
  Calculating upgrade...
  The following packages have been kept back:
    dotnet-runtime-6.0
  The following packages will be upgraded:
    aspnetcore-runtime-6.0 aspnetcore-targeting-pack-6.0 dotnet-apphost-pack-6.0
    dotnet-hostfxr-6.0 dotnet-sdk-7.0 dotnet-targeting-pack-6.0 firefox
    grub-efi-amd64-bin grub-efi-amd64-signed netstandard-targeting-pack-2.1
    powershell
  11 upgraded, 0 newly installed, 0 to remove and 1 not upgraded.
  Need to get 184 MB of archives.
(...)
  Setting up grub-efi-amd64-bin (2.06-2ubuntu14.1) ...
  Setting up grub-efi-amd64-signed (1.187.3~22.04.1+2.06-2ubuntu14.1) ...
  mount: /var/lib/grub/esp: special device /dev/disk/by-id/scsi-14d534654202020200690df035523a242afc173af9e57f2a4-part15 does not exist.
  dpkg: error processing package grub-efi-amd64-signed (--configure):
   installed grub-efi-amd64-signed package post-installation script subprocess returned error exit status 32
  Processing triggers for mailcap (3.70+nmu1ubuntu1) ...
  Processing triggers for hicolor-icon-theme (0.17-2) ...
  Processing triggers for man-db (2.10.2-1) ...
  Errors were encountered while processing:
   grub-efi-amd64-signed
  needrestart is being skipped since dpkg has failed
  E: Sub-process /usr/bin/dpkg returned an error code (1)
Error: The process '/usr/bin/sudo' failed with exit code 100

This is clearly just a workaround and needs an upstream fix from Ubuntu, but with this change the action is usable again.

@lhstrh lhstrh requested a review from a team as a code owner February 25, 2023 00:47
@lhstrh lhstrh requested review from emersonknapp and jhdcs and removed request for a team February 25, 2023 00:47
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 93.14% // Head: 93.18% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (b128877) compared to base (967c886).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b128877 differs from pull request most recent head 96cbfe9. Consider uploading reports for the commit 96cbfe9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
+ Coverage   93.14%   93.18%   +0.03%     
==========================================
  Files           8        8              
  Lines         175      176       +1     
  Branches       17       17              
==========================================
+ Hits          163      164       +1     
  Misses         12       12              
Impacted Files Coverage Δ
src/setup-ros-linux.ts 97.72% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@christophebedard
Copy link
Member

Thanks for the fix! Would you mind signing off your commit?

Signed-off-by: Marten Lohstroh <marten@berkeley.edu>
@lhstrh
Copy link
Contributor Author

lhstrh commented Feb 25, 2023

Thanks for the fix! Would you mind signing off your commit?

Done!

@christophebedard
Copy link
Member

Let's go with this temporary fix for now. Then once this is properly fixed, we can remove this.

@christophebedard christophebedard changed the title Urgent Quick Fix: Make this action work again Temporarily work around apt error with grub-efi-amd64-signed Feb 25, 2023
@christophebedard christophebedard merged commit 03b4488 into ros-tooling:master Feb 25, 2023
dkroenke added a commit to ApexAI/iceoryx that referenced this pull request Feb 27, 2023
…ssue

This refers to ros-tooling/setup-ros#543

Signed-off-by: Dietrich Krönke <dietrich.kroenke@apex.ai>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants