Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add lidar_mirror_fov_reshaper to distribution.yaml #44593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreas-loeffler
Copy link

Please add the following dependency to the rosdep database.

Package name:

lidar_mirror_fov_reshaper

Package Upstream Source:

https://github.com/ioskn/lidar_mirror_fov_reshaper.git

Purpose of using this:

This project provides functionality to calibrate and reshape the field of view (FOV) of a 2D-Lidar sensor, enhanced by two mirrors.

Distro packaging links:

Links to Distribution Packages

Please Add This Package to be indexed in the rosdistro.

rolling

The source is here:

https://github.com/ioskn/lidar_mirror_fov_reshaper/tree/rolling

Checks

  • All packages have a declared license in the package.xml
  • This repository has a LICENSE file
  • This package is expected to build on the submitted rosdistro

@github-actions github-actions bot added the rolling Issue/PR is for the ROS 2 Rolling distribution label Feb 24, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending a pull request to ROS distro!

This is an automated tool that helps check your pull request for correctness.
This tool checks a number of attributes associated with your ROS package and generates a report that helps our reviewers merge your pull request in a timely fashion. Here are a few things to consider when sending adding or updating a package to ROS Distro.
ROS Distro includes a very helpful CONTRIBUTING.md file that we recommend reading if it is your first time submitting a package.
Please also read the ROS Distro review guidelines which summarizes this release process.

ROS Distro Considerations

Package Considerations

Having your package included in a ROS Distro is a badge of quality, and we recommend that package developers strive to create packages of the highest quality. We recommend package developers review the following resources before submitting their package.

Need Help?

Please post your questions to Robotics Stack Exchange or refer to the #infra-help channel on our Discord server.


For changes related to yamllint:

  • ✅ All new lines of YAML pass linter checks

Copy link
Member

@cottsay cottsay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stanza needs to be added to the list of repositories in alphabetical order.

Other than that, I see that this will bring in 3 new packages:

  • lidar_mirror_fov_reshaper_calibration
  • lidar_mirror_fov_reshaper_runtime
  • lidar_mirror_fov_reshaper_transformation

I believe the package names are okay, as the intent is clearly to provide this functionality independent of any particular hardware.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rolling Issue/PR is for the ROS 2 Rolling distribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants