Implementation of EIP-1898 in RSKj JSON-RPC Methods #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vovchyk
changed the title
heitorfm
previously approved these changes
Jul 13, 2021
fedejinich
force-pushed
the
eip1898-jrpc-methods
branch
from
8da42ef to
4b9d64e
Compare
|
rebased for sec review |
|
can I squash the story ? @Vovchyk |
|
LGTM. A possible improvement is already mentioned on the PR:
But this does not pose any risk at all. The search will be slower but does not scale with input ;) |
|
pipeline: run |
Vovchyk
force-pushed
the
eip1898-jrpc-methods
branch
from
3557150 to
0014b9e
Compare
Vovchyk
force-pushed
the
eip1898-jrpc-methods
branch
from
75c2909 to
44d1783
Compare
|
pipeline: run |
…4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3" }
…-hash and is required
…lockNumber": "0x0" }
…sh": "0xd4e56740f876aef8c010b86a40d5f56745a118d0906a34e69aec8c0db1cb8fa3" }
…cal-block-hash and is required
…x<non-canonical-block-hash>" } -> return tx count at given address in specified bloc - test added
…ionCount tests added
…eplaced by hardcoded value in test - #1515 (comment)
… getBalanceByBlockHash to toInvokeByBlockHash as is detailed in #1515 (comment)
…ockHash creation extracted to a private method - #1515 (comment)
…nvokeByBlockHash creation to a private method - #1515 (comment)
…cal type in toInvokeByBlockHash method to boolean - #1515 (comment)
…creating method object to replace multiline params in getBalance tests -#1515 (review)
…non-canonical block add to chain cration in getBalance tests -#1515 (review)
…getTransactionCountBy tests -#1515 (review)
…ry catch way - TestUtil assertThrows reused -#1515 (review)
…r each method - eth_getStorageAt test added g-#1515 (review)
…r each method - eth_getCode tests added g-#1515 (review)
…assertions parametrization -#1515 (review)
…creation chain for testing refactor -#1515 (review)
…r each method - eth_call tests added g-#1515 (review)
…r each method - comments removed -#1515 (review)
Vovchyk
force-pushed
the
eip1898-jrpc-methods
branch
from
e6e2835 to
24bbacd
Compare
|
Kudos, SonarCloud Quality Gate passed! |
heitorfm
approved these changes
Sep 13, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement EIP-1898 in RSKj JSON-RPC Methods.
The following methods were done to support EIP-1898:
Originated from #1515
Motivation and Context
More details here.
How Has This Been Tested?
Types of changes
Checklist:
Code Coverage
Attached coverage.zip you can find all the code coverage reports but you can see that the changes done are 100% covered, as the following image shows.
You can find it in coverage/ns-57/sources/source-c.html in the attached coverage reports.
Demonstration
Here you can see a demonstration about some methods supporting EIP-1898.
rskj-node initialization
Also you can find it in the attached requests.txt
Improvements
In case of search by blockHash, 2 searches are done (one for blockHash and other by blockNumber), this could be avoided by adding blockHash search logic in Web3InformationRetriever.