Skip to content

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Jul 6, 2023

Adds tooltip(), update_tooltip(), and toggle_tooltip()

@cpsievert cpsievert marked this pull request as draft July 6, 2023 20:59
@cpsievert cpsievert requested a review from gadenbuie July 6, 2023 21:00
@cpsievert cpsievert marked this pull request as ready for review July 12, 2023 23:50
@cpsievert
Copy link
Collaborator Author

@gadenbuie this is ready for another (closer) look

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Here are comments and thoughts from the R side, I'll read through the JS side later today.

R/tooltip.R Outdated

#' @describeIn tooltip Update the contents of a tooltip.
#' @export
tooltip_update <- function(id, ..., session = get_current_session()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we support updating other aspects of the tooltip, like placement or options?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, maybe in the future?

Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! :shipit:

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants