Merge pull request #143 from koic/fix_false_positive_for_string_include

Make a safe detection for `Performance/StringInclude`

lib/rubocop/cop/performance/string_include.rb

@@ -22,7 +22,7 @@ class StringInclude < Cop
 
         def_node_matcher :redundant_regex?, <<~PATTERN
           {(send $!nil? {:match :=~ :match?} (regexp (str $#literal?) (regopt)))
-           (send (regexp (str $#literal?) (regopt)) {:match :match?} $_)
+           (send (regexp (str $#literal?) (regopt)) {:match :match?} $str)
            (match-with-lvasgn (regexp (str $#literal?) (regopt)) $_)}
         PATTERN
 

spec/rubocop/cop/performance/string_include_spec.rb

@@ -10,8 +10,8 @@
     end
 
     it "autocorrects /abc/#{method} str" do
-      new_source = autocorrect_source("/abc/#{method} str")
-      expect(new_source).to eq "str.include?('abc')"
+      new_source = autocorrect_source("/abc/#{method} 'str'")
+      expect(new_source).to eq "'str'.include?('abc')"
     end
 
     # escapes like "\n"
@@ -24,8 +24,8 @@
       end
 
       it "autocorrects /\\#{str}#{method} str/" do
-        new_source = autocorrect_source("/\\#{str}/#{method} str")
-        expect(new_source).to eq %{str.include?("\\#{str}")}
+        new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
+        expect(new_source).to eq %{'str'.include?("\\#{str}")}
       end
     end
 
@@ -37,8 +37,8 @@
       end
 
       it "autocorrects /\\#{str}/#{method} str" do
-        new_source = autocorrect_source("/\\#{str}/#{method} str")
-        expect(new_source).to eq "str.include?('#{str}')"
+        new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
+        expect(new_source).to eq "'str'.include?('#{str}')"
       end
 
       it "doesn't register an error for str#{method} /prefix#{str}/" do
@@ -69,8 +69,8 @@
       end
 
       it "autocorrects /\\#{str}#{method} str/" do
-        new_source = autocorrect_source("/\\#{str}/#{method} str")
-        expect(new_source).to eq "str.include?('#{str}')"
+        new_source = autocorrect_source("/\\#{str}/#{method} 'str'")
+        expect(new_source).to eq "'str'.include?('#{str}')"
       end
     end
 
@@ -80,7 +80,7 @@
     end
 
     it "formats the error message correctly for /abc/#{method} str" do
-      inspect_source("/abc/#{method} str")
+      inspect_source("/abc/#{method} 'str'")
       expect(cop.messages).to eq(['Use `String#include?` instead of a regex match with literal-only pattern.'])
     end
 
@@ -90,8 +90,8 @@
     end
 
     it "autocorrects /\\\\/#{method} str" do
-      new_source = autocorrect_source("/\\\\/#{method} str")
-      expect(new_source).to eq("str.include?('\\\\')")
+      new_source = autocorrect_source("/\\\\/#{method} 'str'")
+      expect(new_source).to eq("'str'.include?('\\\\')")
     end
   end
 
@@ -102,4 +102,11 @@
   it 'allows match without a receiver' do
     expect_no_offenses('expect(subject.spin).to match(/\A\n/)')
   end
+
+  # Symbol object does not have `include?` method.
+  # A variable possible to be a symbol object, so if `match?` argument is
+  # a variable, accept it.
+  it 'allows argument of `match?` is not a string literal' do
+    expect_no_offenses('/ /.match?(content_as_symbol)')
+  end
 end