Make a safe detection for Performance/StringInclude
#143
+19
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a safe detection for
Performance/StringInclude
cop whenmatch?
argument is a variable.Symbol object does not have an
include?
method.The following is an auto-corrected example code.
A variable possible to be a symbol object, so if
match?
argument is a variable, accept it.As an unsafe option it might be possible to provide detection when argument is a variable.
First of all, this PR makes detection safe.
This PR haven't added a changelog entry as it is an unreleased feature.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.