Drop support for Rails 4.2 #251
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 4.2 is [no longer officially maintained][0]. Users of Rails 4.2 are still of course welcome to use older versions of this gem. [0]: https://guides.rubyonrails.org/maintenance_policy.html
|
The current version of the gem still works well with Rails 4.2, so I am not sure if its worth going hardcore and dropping support for it? #256 should fix failing tests. Rests should work, right? |
|
Yeah, if it's not a burden to keep support for Rails 4.2 in the codebase, then there's not a really compelling reason to drop support. That said, Rails 4.x users can always just install an older version. |
|
We still use this with a 4.2 app, so I'd vote for keeping it around unless it becomes too much of a pain to deal with. |
|
Rails 4.2 does not seem to require any extra changes in the code and everything seems to work smoothly, so there is no reason to drop it and cut people off from latest improvements. Thanks for your PR anyway! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.2 is no longer officially maintained. This PR updates the README to make clear that Rails 4.2 is not supported by
configand also drops Rails 4.2 from the test suite.