Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use sprockets 3.x for Rails 4.2 #256

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Conversation

qnighy
Copy link
Contributor

@qnighy qnighy commented Nov 29, 2019

To fix CI errors in #255.

@jcoyne
Copy link

jcoyne commented Dec 29, 2019

Committers, please merge this or #262, so we can continue to work on other issues without having to deal with a broken build.

@qnighy
Copy link
Contributor Author

qnighy commented Dec 29, 2019

cc: @pkuczynski or someone for merging #251, #254, #256 or #262

@pkuczynski
Copy link
Member

I will have a look tomorrow when I am back home.

@jcoyne jcoyne mentioned this pull request Jan 2, 2020
Fryguy
Fryguy previously approved these changes Jan 2, 2020
Copy link
Member

@Fryguy Fryguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkuczynski This looks good to me and unsticks CI 👍

@qnighy
Copy link
Contributor Author

qnighy commented Jan 3, 2020

Still unable to merge by myself

image

@pkuczynski pkuczynski changed the title Fix CI: use sprockets 3.x for Rails 4.2 Use sprockets 3.x for Rails 4.2 Jan 3, 2020
@pkuczynski
Copy link
Member

Merged! Sorry for the delay...

@pkuczynski pkuczynski added this to the 2.2.0 milestone Jan 3, 2020
@pkuczynski pkuczynski added the bug label Jan 3, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants