Skip to content

publish: Change "unknown categories" warning to error #8930

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Jun 25, 2024

Resolves #1765

@Turbo87 Turbo87 requested a review from a team June 25, 2024 20:45
@Turbo87 Turbo87 added C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works A-backend ⚙️ labels Jun 25, 2024
Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.64%. Comparing base (308a2cf) to head (26ead88).
Report is 3 commits behind head on main.

Current head 26ead88 differs from pull request most recent head de3c340

Please upload reports for the commit de3c340 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8930   +/-   ##
=======================================
  Coverage   88.64%   88.64%           
=======================================
  Files         276      276           
  Lines       27644    27645    +1     
=======================================
+ Hits        24506    24507    +1     
  Misses       3138     3138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Adam Harvey <adam@adamharvey.name>
@Turbo87 Turbo87 enabled auto-merge June 26, 2024 10:31
@Turbo87 Turbo87 merged commit de5f07f into rust-lang:main Jun 26, 2024
7 checks passed
@Turbo87 Turbo87 deleted the invalid-categories branch June 26, 2024 10:39
baude added a commit to baude/netavark that referenced this pull request Aug 1, 2024
To publish our crate, we must use official categories.  In this case,
"virtualization" specifically calls out containers and seems
appropriate.

Upstream: rust-lang/crates.io#8930

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/aardvark-dns that referenced this pull request Aug 1, 2024
To publish our crate, we must use official categories.  In this case, "virtualization" specifically calls out containers and seems appropriate.

Upstream: rust-lang/crates.io#8930

Signed-off-by: Brent Baude <bbaude@redhat.com>
baude added a commit to baude/aardvark-dns that referenced this pull request Aug 1, 2024
To publish our crate, we must use official categories.  In this case, "virtualization" specifically calls out containers and seems appropriate.

Upstream: rust-lang/crates.io#8930

Signed-off-by: Brent Baude <bbaude@redhat.com>
mheon pushed a commit to mheon/netavark that referenced this pull request Aug 1, 2024
To publish our crate, we must use official categories.  In this case,
"virtualization" specifically calls out containers and seems
appropriate.

Upstream: rust-lang/crates.io#8930

Signed-off-by: Brent Baude <bbaude@redhat.com>
Luap99 pushed a commit to Luap99/aardvark-dns that referenced this pull request Sep 23, 2024
To publish our crate, we must use official categories.  In this case, "virtualization" specifically calls out containers and seems appropriate.

Upstream: rust-lang/crates.io#8930

Signed-off-by: Brent Baude <bbaude@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-backend ⚙️ C-enhancement ✨ Category: Adding new behavior or a change to the way an existing feature works
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"the following are not valid category slugs and were ignored" should be error instead of warning
2 participants