Fix test now that overflowing_literals is rejected in all editions. #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default for mdbook is 2015, so this was testing old behavior. Now that overflowing_literals is deny-by-default on all editions, the test was failing. This updates for the new behavior.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 28, 2019
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Mar 1, 2019
Update edition-guide 15 commits in 419edb885ec1a98c0747b3907003d79e3e6b93a9..5f3cc2a5618700efcde3bc00799744f21fa9ad2e 2018-12-04 16:43:38 -0500 to 2019-02-27 20:11:50 -0800 - Migrate to mdbook 0.2. (rust-lang/edition-guide#152) - Remove automatic deployment. (rust-lang/edition-guide#151) - Fix issue with rust's linkchecker and mdbook. (rust-lang/edition-guide#147) - Fix test now that overflowing_literals is rejected in all editions. (rust-lang/edition-guide#148) - overflowing_literals is deny on all editions (rust-lang/edition-guide#146) - Update for uniform_path stabilization. (rust-lang/edition-guide#141) - Add example to rustup to show overriding to specific version (rust-lang/edition-guide#144) - Update for anonymous-lifetime stabilization. (rust-lang/edition-guide#142) - Add minimum Rust version for Kleene operator (rust-lang/edition-guide#137) - Add 2018-specific changes. (rust-lang/edition-guide#130) - aborting-on-panic.md: Typo in example config (rust-lang/edition-guide#125) - Clarify uniform paths are not yet in Rust 2018 (rust-lang/edition-guide#124) - update several version numbers - Fixes outdated link (rust-lang/edition-guide#131) - Fixed typo in transitioning page. (rust-lang/edition-guide#127)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default for mdbook is 2015, so this was testing old behavior.
Now that overflowing_literals is deny-by-default on all editions,
the test was failing. This updates for the new behavior.