Enable an option for portable-atomic #2670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks!
Ah, the (CI failure is probably a problem addressed in rust-lang/miri#2713 I guess it will be fixed after the next Miri update) |
taiki-e
approved these changes
Dec 7, 2022
taiki-e
added
the
0.3-backport: pending
taiki-e
added
0.3-backport: completed
and removed
0.3-backport: pending
taiki-e
pushed a commit
that referenced
this pull request
Jan 30, 2023
taiki-e
pushed a commit
that referenced
this pull request
Jan 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables an option in
futures-corethat replaces the atomic usage inAtomicWakerwithportable-atomic, and also exposes that flag infutures-util. This intends to make it sofutures-corecan be used on platforms without atomics, like AVR.I look through
futures-utiland didn't see any other usage of atomics that wasn't also locked behind allocation, so I think this is the best I can do here.