Skip to content

for now, do not do fake reads on non-Unpin mutable references #2713

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Dec 3, 2022

Work-around for rust-lang/unsafe-code-guidelines#381, needed to make the new test pass. Undoes parts of #2694.

@RalfJung
Copy link
Member Author

RalfJung commented Dec 3, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Dec 3, 2022

📌 Commit 30e3ca7 has been approved by RalfJung

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Dec 3, 2022

⌛ Testing commit 30e3ca7 with merge 5d2ee92...

@bors
Copy link
Contributor

bors commented Dec 3, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 5d2ee92 to master...

@bors bors merged commit 5d2ee92 into rust-lang:master Dec 3, 2022
@RalfJung RalfJung deleted the not-unpin-fake-read branch December 4, 2022 10:20
bors bot pushed a commit to bevyengine/bevy that referenced this pull request Dec 11, 2022
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- rust-lang/miri#2713 was merged into miri. See if this fixes miri for bevy.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants