Skip to content

Support partial stashing #930

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
May 25, 2023
Merged

Conversation

extrawurst
Copy link
Contributor

@extrawurst extrawurst commented Feb 17, 2023

Work in Progress.
Need some help here: I guess updating the submodule breaks a lot of things. I did not dive into their release pipeline but it seems releases are cherry picked. I will wait for another release that contains the new feature

closes #929

  • new types and fn's
  • new safe api

@extrawurst
Copy link
Contributor Author

so the API is done, but I am a little lost as to why the test does not work, even though I specify a pathspec, both file changes are gone after the stash 🤯

@extrawurst extrawurst marked this pull request as ready for review April 21, 2023 21:04
try getting tests to work again

fix tests

cleanup

safe api

fix unittest
@extrawurst extrawurst force-pushed the support-partial-stashing branch from 9c3d67d to 672a0f3 Compare April 21, 2023 21:05
@extrawurst
Copy link
Contributor Author

this PR is ready for merge @ehuss

extrawurst and others added 2 commits May 17, 2023 19:42
Co-authored-by: Eric Huss <eric@huss.org>
@extrawurst
Copy link
Contributor Author

@ehuss I addressed your feedback

@extrawurst extrawurst requested a review from ehuss May 25, 2023 11:39
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit d95cc38 into rust-lang:master May 25, 2023
@extrawurst
Copy link
Contributor Author

extrawurst commented May 25, 2023

@ehuss thanks for merging can you cut a release please? :)

@ehuss
Copy link
Contributor

ehuss commented May 28, 2023

Sure! It should be published now.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support new partial stashing API
2 participants