-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Convert mode_t constants to octal #3634
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
☔ The latest upstream changes (presumably #3654) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased to fix conflict with #3654 in src/fuchsia/mod.rs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
(backport <rust-lang#3634>) (cherry picked from commit 3cc3f01)
(backport <rust-lang#3634>) (cherry picked from commit 3cc3f01)
(backport <rust-lang#3634>) (cherry picked from commit 3cc3f01)
For example the "user read write execute" value is most appropriately represented in the following octal form:
as opposed to what is currently found in libc, which is representations like:
libc/src/fuchsia/mod.rs
Line 1478 in a0f5b4b
libc/src/wasi.rs
Line 258 in a0f5b4b
The glibc manual consistently uses octal when describing values of mode_t, as in
0400
or02000
.This PR is generated by this script: