-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[0.2] Backports #4017
[0.2] Backports #4017
Conversation
r? @JohnTitor rustbot has assigned @JohnTitor. Use |
539bbaf
to
cc2f5aa
Compare
☔ The latest upstream changes (presumably #4016) made this pull request unmergeable. Please resolve the merge conflicts. |
cc2f5aa
to
acb03cc
Compare
Including #4019 so this can merge without conflict |
acb03cc
to
2eb8321
Compare
(backport <rust-lang#3864>) (cherry picked from commit ec3c338)
Constants added from [this commit]. [this commit]: illumos/illumos-gate@0250c53 Additionally, resolves some issues introduced in ec3c338 ("Fix tests on Solaris"). [ add note about fixing ec3c338 - Trevor ] (backport <rust-lang#3999>) (cherry picked from commit e2a23f0)
Illumos reference (originally included in Solaris): https://github.com/illumos/illumos-gate/blob/aaceae985c2e78cadef76bf0b7b50ed887ccb3a6/usr/src/head/fnmatch.h#L41 (backport <rust-lang#4004>) (cherry picked from commit 98a20b3)
2eb8321
to
61150a4
Compare
Did this result in a breaking change in the 0.2 releases? Thats at least how it sounds from rust-lang/cargo#15143 |
It was not mentioned specifically but Solaris does not have |
But removing the |
They should not have been removed from illumos right? Lines 1571 to 1575 in 0f9f8c9
|
Sorry, I misread and through the |
[0.2] Backports
Backport the following Solaris changes:
Also cherry picks the backport of #3634 so this can start before #4016 merges.