Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

i686-unknown-openbsd libc correction #462

Merged
merged 2 commits into from
Dec 2, 2016

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Dec 2, 2016

Now I had been able to run testsuite on i686-unknown-openbsd, here a batch of corrections.

  • suseconds_t is c_long (i64 or i32 depending the arch)
  • struct siginfo_t padding adjustment (the pointer si_addr makes the pad to change depending pointer size)

I tested the PR on i686-unknown-openbsd and x86_64-unknown-openbsd.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 2, 2016

📌 Commit 2126c45 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 2, 2016

⌛ Testing commit 2126c45 with merge a387b9a...

bors added a commit that referenced this pull request Dec 2, 2016
i686-unknown-openbsd libc correction

Now I had been able to run testsuite on i686-unknown-openbsd, here a batch of corrections.

- `suseconds_t` is `c_long` (`i64` or `i32` depending the arch)
- struct siginfo_t padding adjustment (the pointer `si_addr` makes the pad to change depending pointer size)

I tested the PR on i686-unknown-openbsd and x86_64-unknown-openbsd.
@bors
Copy link
Contributor

bors commented Dec 2, 2016

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

alexcrichton commented Dec 2, 2016 via email

@bors
Copy link
Contributor

bors commented Dec 2, 2016

⌛ Testing commit 2126c45 with merge 87f7a6a...

bors added a commit that referenced this pull request Dec 2, 2016
i686-unknown-openbsd libc correction

Now I had been able to run testsuite on i686-unknown-openbsd, here a batch of corrections.

- `suseconds_t` is `c_long` (`i64` or `i32` depending the arch)
- struct siginfo_t padding adjustment (the pointer `si_addr` makes the pad to change depending pointer size)

I tested the PR on i686-unknown-openbsd and x86_64-unknown-openbsd.
@bors
Copy link
Contributor

bors commented Dec 2, 2016

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Dec 2, 2016

⌛ Testing commit 2126c45 with merge 0ac39c5...

bors added a commit that referenced this pull request Dec 2, 2016
i686-unknown-openbsd libc correction

Now I had been able to run testsuite on i686-unknown-openbsd, here a batch of corrections.

- `suseconds_t` is `c_long` (`i64` or `i32` depending the arch)
- struct siginfo_t padding adjustment (the pointer `si_addr` makes the pad to change depending pointer size)

I tested the PR on i686-unknown-openbsd and x86_64-unknown-openbsd.
@bors
Copy link
Contributor

bors commented Dec 2, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 0ac39c5 to master...

@bors bors merged commit 2126c45 into rust-lang:master Dec 2, 2016
@semarie semarie deleted the openbsd-i686-correct branch December 5, 2016 05:27
@semarie
Copy link
Contributor Author

semarie commented Jan 4, 2017

@alexcrichton is it possible to release a new (minor) version of libc ? it is a bit annoying to have to patch 0.2.18 to have proper libc supports for openbsd i686. thanks.

@alexcrichton
Copy link
Member

@semarie sure yeah, that's #487

@semarie
Copy link
Contributor Author

semarie commented Jan 5, 2017

thanks !

Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Update CHANGELOD.md to include CLONE_NEWCGROUP

Add note about CLONE_NEWCGROUP from pull request rust-lang#457 to CHANGELOG.md.

Signed-off-by: Dylan Reid <dgreid@chromium.org>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants