Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add i686-unknown-openbsd target. #38086

Merged
merged 3 commits into from
Dec 4, 2016
Merged

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Nov 30, 2016

It is a preliminary work. I still have some tests failing, but I have a working rustc binary which is able to rebuild itself.

an update of libc should be required too, but I dunno how to do it with vendor/ layout.

r? @alexcrichton

@japaric
Copy link
Member

japaric commented Nov 30, 2016

LGTM.

an update of libc should be required too, but I dunno how to do it with vendor/ layout.

At the very least, you'll need to update the src/liblibc submodule in this PR. I don't know the specifics about cargo vendoring though.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 1, 2016

📌 Commit 40c609c has been approved by alexcrichton

@semarie
Copy link
Contributor Author

semarie commented Dec 2, 2016

@alexcrichton Could you unapprove this PR for now please ?

I have pending PR in libc (rust-lang/libc#462) that would require a new liblibc for i686-unknown-openbsd correctness.

I will update this PR once libc PR be accepted.

@japaric
Copy link
Member

japaric commented Dec 2, 2016

@bors r-

Let's wait for that libc PR

@semarie
Copy link
Contributor Author

semarie commented Dec 4, 2016

I updated liblibc submodule.
I also added OpenBSD in librustc_trans/cabi_x86.rs as target requiring particular management for returning a struct (small structs are returned as integers).

It is like OSX or Windows: small structs are returned as integers.
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 4, 2016

📌 Commit 6774e7a has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Dec 4, 2016

⌛ Testing commit 6774e7a with merge 2190f6c...

bors added a commit that referenced this pull request Dec 4, 2016
Add i686-unknown-openbsd target.

It is a preliminary work. I still have some tests failing, but I have a working rustc binary which is able to rebuild itself.

an update of libc should be required too, but I dunno how to do it with vendor/ layout.

r? @alexcrichton
@bors bors merged commit 6774e7a into rust-lang:master Dec 4, 2016
@semarie semarie deleted the openbsd-i686 branch December 5, 2016 05:27
@semarie
Copy link
Contributor Author

semarie commented Dec 6, 2016

this kind of "restructuration" was outside the scope of the PR, but I tend to agree with this approch, and it could be generalized to a list of options registered by target for required behaviour.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants