-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add i686-unknown-openbsd target. #38086
Conversation
LGTM.
At the very least, you'll need to update the |
@bors: r+ |
📌 Commit 40c609c has been approved by |
@alexcrichton Could you unapprove this PR for now please ? I have pending PR in libc (rust-lang/libc#462) that would require a new liblibc for i686-unknown-openbsd correctness. I will update this PR once libc PR be accepted. |
@bors r- Let's wait for that libc PR |
I updated liblibc submodule. |
It is like OSX or Windows: small structs are returned as integers.
@bors: r+ |
📌 Commit 6774e7a has been approved by |
⌛ Testing commit 6774e7a with merge 2190f6c... |
Add i686-unknown-openbsd target. It is a preliminary work. I still have some tests failing, but I have a working rustc binary which is able to rebuild itself. an update of libc should be required too, but I dunno how to do it with vendor/ layout. r? @alexcrichton
this kind of "restructuration" was outside the scope of the PR, but I tend to agree with this approch, and it could be generalized to a list of options registered by target for required behaviour. |
It is a preliminary work. I still have some tests failing, but I have a working rustc binary which is able to rebuild itself.
an update of libc should be required too, but I dunno how to do it with vendor/ layout.
r? @alexcrichton