Skip to content

Make from/to_bitmask not depend on generic_const_exprs #223

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
jorgecarleitao opened this issue Jan 13, 2022 · 0 comments · Fixed by #239
Closed

Make from/to_bitmask not depend on generic_const_exprs #223

jorgecarleitao opened this issue Jan 13, 2022 · 0 comments · Fixed by #239

Comments

@jorgecarleitao
Copy link
Contributor

I.e. these are under generic_const_exprs which will take some time to stabilize.

Goal: find a way of re-writing those two functions without using generic_const_exprs

@jorgecarleitao jorgecarleitao changed the title Re-write from/to_bitmap without const_generics so that it is usable Make from/to_bitmap not depend on generic_const_exprs Jan 13, 2022
@jorgecarleitao jorgecarleitao changed the title Make from/to_bitmap not depend on generic_const_exprs Make from/to_bitmask not depend on generic_const_exprs Jan 13, 2022
workingjubilee added a commit that referenced this issue Feb 26, 2022
Another approach that fixes #223, as an alternative to #238.

This adds the `ToBitMask` trait, which is implemented on a vector for each bitmask type it supports.  This includes all unsigned integers with enough bits to contain it.  The byte array variant has been separated out for now into #246 and still requires `generic_const_exprs`, but the integer variants no longer require it and can make it to nightly.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
1 participant