Removed need for generic_const_expr in bitmask #238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Problem is: GitHub itself. Cool. |
|
I should mention I took a stab at a more complete solution for this in the |
|
I just posted #239 with the changes I was talking about, we can compare these two PRs. |
|
fwiw, I am fine with any. This is hopefully the last blocking issue forbiding arrow2 from adopting portable-simd. So either PR is fine - I would just like to give this a spin without the major performance regression vs packed_simd. |
workingjubilee
added a commit
that referenced
this pull request
Feb 26, 2022
Another approach that fixes #223, as an alternative to #238. This adds the `ToBitMask` trait, which is implemented on a vector for each bitmask type it supports. This includes all unsigned integers with enough bits to contain it. The byte array variant has been separated out for now into #246 and still requires `generic_const_exprs`, but the integer variants no longer require it and can make it to nightly.
|
Resolved in #239. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223