Recognize inline namespaces using clang's dedicated API for that #2951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtolnay
commented
Oct 16, 2024
|
|
||
| /// Is this cursor's referent a namespace that is inline? | ||
| pub(crate) fn is_inline_namespace(&self) -> bool { | ||
| unsafe { clang_Cursor_isInlineNamespace(self.x) != 0 } |
There was a problem hiding this comment.
According to https://docs.rs/clang-sys/1.8.1/clang_sys/fn.clang_Cursor_isInlineNamespace.html, this function is available in libclang 9.0 and later.
Since #2932, bindgen only supports libclang 9.0 or later.
There was a problem hiding this comment.
Thanks for saving me the time of checking it :)
|
CI failures appear unrelated. I sent a fix in #2952. |
dtolnay
force-pushed
the
inlinenamespace
branch
from
0e5f22b to
01c99ab
Compare
emilio
approved these changes
Nov 28, 2024
|
|
||
| /// Is this cursor's referent a namespace that is inline? | ||
| pub(crate) fn is_inline_namespace(&self) -> bool { | ||
| unsafe { clang_Cursor_isInlineNamespace(self.x) != 0 } |
There was a problem hiding this comment.
Thanks for saving me the time of checking it :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2950.