Add rustfix tests for mistyped_literal_suffix lint #3888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rustfmt on |
flip1995
added
the
S-waiting-on-author
|
0ba45a9 should make the build pass once Clippy builds again. I'm not available until Monday so feel free to r+ once it works =) |
|
@bors r+ |
|
📌 Commit 0ba45a9 has been approved by |
|
@bors r=flip1995 |
|
📌 Commit 0ba45a9 has been approved by |
|
💔 Test failed - checks-travis |
The moved tests were part of `tests/ui/literals.rs` before. Now they are placed in `tests/ui/unreadable_literal.rs`, which now also runs `rustfix` on these 4 extra let statements.
This moves all `mistyped_literal_suffix` tests to their own file and enables rustfix tests for them. cc rust-lang#3603, rust-lang#2038 Based on rust-lang#3887
phansch
force-pushed
the
extract_mistyped_literal_suffix_tests_and_rustfix
branch
from
0ba45a9 to
0452704
Compare
|
@bors r=flip1995 |
|
📌 Commit 0452704 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all
mistyped_literal_suffixtests to their own file andenables rustfix tests for them.
cc #3603, #2038
Based on #3887