Skip to content

Rustup #3893

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 20 commits into from
Mar 18, 2019
Merged

Rustup #3893

merged 20 commits into from
Mar 18, 2019

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Mar 18, 2019

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899

@mati865 mati865 mentioned this pull request Mar 18, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 18, 2019

📌 Commit 8cfc91b has been approved by oli-obk

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 8cfc91b with merge 4895097...

@mati865
Copy link
Contributor Author

mati865 commented Mar 18, 2019

Formatting with --all this time...

@bors retry

@bors
Copy link
Contributor

bors commented Mar 18, 2019

@mati865: 🔑 Insufficient privileges: not in try users

@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Mar 18, 2019

📌 Commit 6cb0605 has been approved by oli-obk

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 6cb0605 with merge a7e0c0b...

@bors
Copy link
Contributor

bors commented Mar 18, 2019

💔 Test failed - checks-travis

@matthiaskrgr
Copy link
Member

  Installing /Users/travis/.cargo/bin/rustup-toolchain-install-master
detecting the channel of the `cd45b19bd2d8b4f9a3940a409ea43285019f3280` toolchain...
error: https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rustc-builds/cd45b19bd2d8b4f9a3940a409ea43285019f3280/rust-src-nightly.tar.xz: timed out
error: toolchain 'master' is not installed
info: backtrace:
stack backtrace:
   0:        0x10cd8bf8e - backtrace::backtrace::trace::hb39615e846d97438
   1:        0x10cd8b1a4 - error_chain::backtrace::imp::InternalBacktrace::new::h42957417422586b4
   2:        0x10c9ebcc1 - rustup_init::rustup_mode::main::ha2b3dbc277471d62
   3:        0x10ca27c4c - rustup_init::run_rustup::he197b959e963ea85
   4:        0x10ca26f87 - rustup_init::main::h9d7da49ccb0c8cc2
   5:        0x10c9cddc5 - std::rt::lang_start::{{closure}}::h11a539400a49a543
   6:        0x10ca2cc68 - _main

@bors retry

@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 6cb0605 with merge 849ac1d...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@bors
Copy link
Contributor

bors commented Mar 18, 2019

💥 Test timed out

@matthiaskrgr
Copy link
Member

@bors retry

@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 6cb0605 with merge 6a0a197...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@mati865
Copy link
Contributor Author

mati865 commented Mar 18, 2019

@flip1995
Copy link
Member

@bors retry p=10

@bors
Copy link
Contributor

bors commented Mar 18, 2019

⌛ Testing commit 6cb0605 with merge 92612c9...

bors added a commit that referenced this pull request Mar 18, 2019
Rustup

Supersedes #3889

Addresses some review comments from previous PR and rustups to rust-lang/rust#58899
@Xanewok
Copy link
Member

Xanewok commented Mar 18, 2019

Please let me know if/when you decide to update tools in the Rust tree - I'd like to update to the current RLS master (which also means pulling in Rustfmt 1.1) in tandem with this.

@mati865
Copy link
Contributor Author

mati865 commented Mar 18, 2019

@Xanewok you can upgrade all the tools in Rust repo at same time if you want.

@bors
Copy link
Contributor

bors commented Mar 18, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 92612c9 to master...

@bors bors merged commit 6cb0605 into rust-lang:master Mar 18, 2019
@mati865 mati865 deleted the rustup branch March 18, 2019 16:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants