Improve unwrap_or_else_default when handling unwrap_or_else(XXX::new)
#8163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
pmnoxx
force-pushed
the
piotr-improve-unwrap-or-default
branch
from
646192a
to
709d2ce
Compare
pmnoxx
force-pushed
the
piotr-improve-unwrap-or-default
branch
from
3304436
to
79cf412
Compare
pmnoxx
force-pushed
the
piotr-improve-unwrap-or-default
branch
from
e2c3e48
to
db236e6
Compare
pmnoxx
changed the title
unwrap_or_else_default - WIPunwrap_or_else_default
pmnoxx
changed the title
unwrap_or_else_defaultunwrap_or_else_default when handling unwrap_or_else(XXX::new)
Manishearth
approved these changes
Dec 24, 2021
|
@bors r+ |
|
📌 Commit 2a47dbc has been approved by |
bors
added a commit
that referenced
this pull request
Dec 24, 2021
…hearth Improve `unwrap_or_else_default` when handling `unwrap_or_else(XXX::new)` changelog: - change `unwrap_or_else_default` to work with std constructors like `Vec::new`, `HashSet::new`, `HashMap::new`. Notes: - Code to handle detecting those constructors is already there. I moved it out to `is_default_equivalent_call`
|
💔 Test failed - checks-action_test |
|
The changelog entry has to be on the same line like the @bors retry |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: change
unwrap_or_else_defaultto work with std constructors likeVec::new,HashSet::new,HashMap::new.Notes:
is_default_equivalent_call