Skip to content

Add [unused_peekable] lint #9258

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 19, 2022
Merged

Add [unused_peekable] lint #9258

merged 2 commits into from
Aug 19, 2022

Conversation

Serial-ATA
Copy link
Contributor

changelog: Add [unused_peekable] lint
closes: #854

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 29, 2022
Alexendoo
Alexendoo reviewed Jul 29, 2022
View reviewed changes
@bors
Copy link
Contributor

bors commented Aug 2, 2022

☔ The latest upstream changes (presumably #9264) made this pull request unmergeable. Please resolve the merge conflicts.

Alexendoo
Alexendoo reviewed Aug 5, 2022
View reviewed changes
@Serial-ATA Serial-ATA force-pushed the unused-peekable branch 2 times, most recently from d28e72b to 5ad13b6 Compare August 5, 2022 18:09
@Serial-ATA
Copy link
Contributor Author

One of the tests has a FN now, I won't be able to fix it for a few days.

@bors
Copy link
Contributor

bors commented Aug 9, 2022

☔ The latest upstream changes (presumably #9288) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Aug 16, 2022

☔ The latest upstream changes (presumably #9040) made this pull request unmergeable. Please resolve the merge conflicts.

@Serial-ATA Serial-ATA force-pushed the unused-peekable branch 3 times, most recently from aaa8cea to 7b62d1f Compare August 16, 2022 21:48
@Serial-ATA Serial-ATA requested a review from Alexendoo August 16, 2022 22:00
Alexendoo
Alexendoo reviewed Aug 18, 2022
View reviewed changes
@bors
Copy link
Contributor

bors commented Aug 19, 2022

☔ The latest upstream changes (presumably #9295) made this pull request unmergeable. Please resolve the merge conflicts.

@Alexendoo
Copy link
Member

Looks good thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 19, 2022

📌 Commit 0efafa4 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 19, 2022

⌛ Testing commit 0efafa4 with merge 2091142...

@bors
Copy link
Contributor

bors commented Aug 19, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 2091142 to master...

@bors bors merged commit 2091142 into rust-lang:master Aug 19, 2022
@Serial-ATA
Copy link
Contributor Author

Thanks for all the help on this @Alexendoo!

@Serial-ATA Serial-ATA deleted the unused-peekable branch August 19, 2022 20:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Alexendoo Alexendoo Alexendoo approved these changes

Assignees

@Alexendoo Alexendoo

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Useless peekable iterator
4 participants
@Serial-ATA @rust-highfive @bors @Alexendoo