Skip to content

Add elapsed_instant lint #9264

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Add elapsed_instant lint #9264

merged 1 commit into from
Aug 2, 2022

Conversation

guerinoni
Copy link
Contributor

@guerinoni guerinoni commented Jul 30, 2022

Closes #8603

  • Followed [lint naming conventions][lint_naming]
  • Added passing UI tests (including committed .stderr file)
  • cargo test passes locally
  • Executed cargo dev update_lints
  • Added lint documentation
  • Run cargo dev fmt

changelog: [elapsed_instant]: Add lint

@rust-highfive
Copy link

r? @Alexendoo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 30, 2022
@guerinoni guerinoni marked this pull request as ready for review July 30, 2022 14:06
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR

@guerinoni guerinoni requested a review from Alexendoo August 1, 2022 10:41
@guerinoni guerinoni requested a review from Alexendoo August 1, 2022 13:59
Copy link
Member

@Alexendoo Alexendoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again just some documentation/formatting left and it'll be good to go

@guerinoni
Copy link
Contributor Author

@Alexendoo Thank you so much :)

@guerinoni guerinoni requested a review from Alexendoo August 1, 2022 20:26
Closes #8603

Signed-off-by: Federico Guerinoni <guerinoni.federico@gmail.com>
@guerinoni guerinoni requested a review from Alexendoo August 1, 2022 21:39
@Alexendoo
Copy link
Member

Thanks!

@bors r+

For what it's worth you don't need to hit the request review button. Since we get a notification on each commit after we're assigned I don't think it actually does anything

@bors
Copy link
Contributor

bors commented Aug 2, 2022

📌 Commit 0696624 has been approved by Alexendoo

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 2, 2022

⌛ Testing commit 0696624 with merge 00e59cd...

@bors
Copy link
Contributor

bors commented Aug 2, 2022

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Alexendoo
Pushing 00e59cd to master...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer instant.elapsed() over Instant::now() - instant
4 participants