Skip to content

./x.py dist fails in rust 1.71.0 on lint-docs #113678

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
jpalus opened this issue Jul 14, 2023 · 7 comments
Closed

./x.py dist fails in rust 1.71.0 on lint-docs #113678

jpalus opened this issue Jul 14, 2023 · 7 comments
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. stable-accepted Accepted for backporting to the compiler in the stable channel. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Milestone
1.71.0

Comments

@jpalus
Copy link

jpalus commented Jul 14, 2023

Build of rust 1.71.0 fails on Linux/aarch64 (bootstrapped by system rust 1.70.0) with:

running: LD_LIBRARY_PATH="/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/lib:/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/lib" RUSTC="/usr/bin/rustc" RUSTC_BOOTSTRAP="1" "/home
/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage0-tools-bin/lint-docs" "--src" "/home/users/builder/rpm/BUILD/rustc-1.71.0-src/compiler" "--out" "/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/
md-doc/rustc/src/lints" "--rustc" "/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "--rustc-target" "aarch64-unknown-linux-gnu" "--verbose"                                                                    
compiling lint forbidden_lint_groups                                                                                                                                                                                                                            
running: cd "/home/users/builder/tmp/.tmpxILHkF" && "/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "--edition=2018" "--error-format=json" "--target" "aarch64-unknown-linux-gnu" "lint_example.rs"           
warning: the code example in lint `forbidden_lint_groups` in /home/users/builder/rpm/BUILD/rustc-1.71.0-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `forbidden_lint_groups` in output of example, got:
/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/bin/rustc: error while loading shared libraries: librustc_driver-c3edb2d0282ade3e.so: cannot open shared object file: No such file or directory                           
                                                                                                                                                                                                                                                                
compiling lint ill_formed_attribute_input                                                                                                                                                                                                                       
running: cd "/home/users/builder/tmp/.tmpoGbUcU" && "/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "--edition=2018" "--error-format=json" "--target" "aarch64-unknown-linux-gnu" "lint_example.rs"           
warning: the code example in lint `ill_formed_attribute_input` in /home/users/builder/rpm/BUILD/rustc-1.71.0-src/compiler/rustc_lint_defs/src/builtin.rs failed to generate the expected output: did not find lint `ill_formed_attribute_input` in output of exa
mple, got:                                                                                                                                                                                                                                                      
/home/users/builder/rpm/BUILD/rustc-1.71.0-src/build/aarch64-unknown-linux-gnu/stage2/bin/rustc: error while loading shared libraries: librustc_driver-c3edb2d0282ade3e.so: cannot open shared object file: No such file or directory

I believe the culprit is explicit removal of LD_LIBRARY_PATH despite it being apparently necessary in this case:

rust/src/tools/lint-docs/src/lib.rs

Line 411 in 8ede3aa

cmd.env_remove("LD_LIBRARY_PATH");

I see on master this was already reverted in 67b5990 but looks like it missed the release.
@jpalus jpalus added the C-bug Category: This is a bug. label Jul 14, 2023
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jul 14, 2023
@Noratrieb
Copy link
Member

@jyn514

@Noratrieb Noratrieb added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jul 14, 2023
@jyn514
Copy link
Member

jyn514 commented Jul 14, 2023

this is a question for t-release, not bootstrap. 67b5990 depends on the whole PR, and that PR changes quite a lot, but the changes are only to download-rustc and not to the rest of the build system.

@jyn514 jyn514 added this to the 1.71.0 milestone Jul 14, 2023
@jyn514 jyn514 added T-release Relevant to the release subteam, which will review and decide on the PR/issue. beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. labels Jul 14, 2023
pld-gitsync pushed a commit to pld-linux/rust that referenced this issue Jul 14, 2023
@jpalus
up to 1.71.0
642cf71 
- fix build by applying upstream revert, see:
  rust-lang/rust#113678
- roll back to original location for bash completion, from:
  rust-lang/rust#113579
@cuviper
Copy link
Member

cuviper commented Jul 15, 2023

67b5990 depends on the whole PR

Why is that? It's a clean git cherry-pick, at least, and I don't see why it would logically depend on the rest of that PR.

@jyn514
Copy link
Member

jyn514 commented Jul 15, 2023

@cuviper it depends on baae59e, or else lint-docs tests will fail when download-rustc and assertions are both enabled.

(and i am considering reverting baae59e soon: #112143 (comment))

@cuviper
Copy link
Member

cuviper commented Jul 17, 2023

or else lint-docs tests will fail when download-rustc and assertions are both enabled.

Well, that seems to me an unlikely combination for stable builds.

@cuviper
Copy link
Member

cuviper commented Jul 28, 2023

We discussed this last week and agreed to pull 67b5990 into 1.71.1:
https://rust-lang.zulipchat.com/#narrow/stream/241545-t-release/topic/meeting.202023.2007.2021/near/377344265

(and to avoid regression, it should go into 1.72-beta as well)

@rustbot label +stable-accepted +beta-accepted

@rustbot rustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Jul 28, 2023
@pietroalbini pietroalbini mentioned this issue Jul 31, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 31, 2023
@bors
Auto merge of rust-lang#114284 - pietroalbini:pa-1.72.1, r=pietroalbini
7c79013 
Prepare Rust 1.71.1

This PR prepares the Rust 1.71.1 release, which contains:

* rust-lang#113802
* rust-lang#113579
* rust-lang#111516
* rust-lang#112517
* rust-lang@67b5990 (from rust-lang#113678)

r? `@ghost`
cc `@rust-lang/release`
@Mark-Simulacrum Mark-Simulacrum added the regression-from-stable-to-stable Performance or correctness regression from one stable version to another. label Aug 18, 2023
@cuviper cuviper removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 21, 2023
@jpalus
Copy link
Author

jpalus commented Aug 25, 2023

I think the issue can be closed now that 1.72.0 was released and includes fix.

@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 25, 2023
@cuviper cuviper closed this as completed Aug 25, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. C-bug Category: This is a bug. regression-from-stable-to-stable Performance or correctness regression from one stable version to another. stable-accepted Accepted for backporting to the compiler in the stable channel. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

No branches or pull requests
6 participants
@cuviper @jpalus @Mark-Simulacrum @jyn514 @rustbot @Noratrieb