suspicious_double_ref_op: don't lint on .borrow()
#112517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @b-naber (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Noratrieb
reviewed
Jun 11, 2023
| @@ -129,6 +129,9 @@ impl<'tcx> LateLintPass<'tcx> for NoopMethodCall { | |||
| NoopMethodCallDiag { method: call.ident.name, receiver_ty, label: span }, | |||
| ); | |||
| } else { | |||
| if op == "borrow" { | |||
There was a problem hiding this comment.
can you add a comment here explaining why borrow makes sense?
| // FIXME(fee1-dead) stop using stringly typed diagnostic here | ||
| // If `type_of(x) == T` and `x.borrow()` is used to get `&T`, | ||
| // gthen that should be allowed | ||
| if op == "borrow" { |
There was a problem hiding this comment.
nit:
Suggested change
| if op == "borrow" { | |
| if name == sym::noop_method_borrow { |
fee1-dead
force-pushed
the
sus-op-no-borrow
branch
from
8e9e54d to
1caed51
Compare
compiler-errors
approved these changes
Jun 15, 2023
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 15, 2023
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#112403 (Prevent `.eh_frame` from being emitted for `-C panic=abort`) - rust-lang#112517 (`suspicious_double_ref_op`: don't lint on `.borrow()`) - rust-lang#112529 (Extend `unused_must_use` to cover block exprs) - rust-lang#112614 (tweak suggestion for argument-position `impl ?Sized`) - rust-lang#112654 (normalize closure output in equate_inputs_and_outputs) - rust-lang#112660 (Migrate GUI colors test to original CSS color format) - rust-lang#112664 (Add support for test tmpdir to fuchsia test runner) - rust-lang#112669 (Fix comment for ptr alignment checks in codegen) r? `@ghost` `@rustbot` modify labels: rollup
|
Should this be backported to the 1.71.0 beta? I'm asking because the issue is listed in the 1.71.0 milestone. |
|
It's too late now for 1.71.0, of course, but it could be considered for 1.71.1. A warn-by-default lint is not such a big deal, but this is a trivial backport (clean cherry-pick), and we're planning to have a point release anyway. FWIW, I also got a bug for this in CentOS Stream: https://bugzilla.redhat.com/show_bug.cgi?id=2225471 @rustbot label +stable-nominated |
rustbot
added
the
stable-nominated
rustbot
added
the
stable-accepted
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2023
Prepare Rust 1.71.1 This PR prepares the Rust 1.71.1 release, which contains: * rust-lang#113802 * rust-lang#113579 * rust-lang#111516 * rust-lang#112517 * rust-lang@67b5990 (from rust-lang#113678) r? `@ghost` cc `@rust-lang/release`
cuviper
removed
the
stable-nominated
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #112489