Skip to content

Tracking Issue for generic NonZero #120257

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
20 of 21 tasks
reitermarkus opened this issue Jan 23, 2024 · 34 comments
Closed
20 of 21 tasks

Tracking Issue for generic NonZero #120257

reitermarkus opened this issue Jan 23, 2024 · 34 comments
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@reitermarkus
Copy link
Contributor

reitermarkus commented Jan 23, 2024 •
edited
Loading

Feature gate: #![feature(generic_nonzero)]

This is a tracking issue for replacing the distinct NonZero* types with a generic NonZero<T> type. This allows using NonZero with FFI type aliases instead of having weird type names like NonZero_c_ulonglong.

This replaces the following tracking issues:

Public API

use core::num::{NonZero, NonZeroU8};

assert_eq!(NonZero::new(33u8), NonZeroU8::new(33));

Steps / History

Unresolved Questions

  • None yet.

Footnotes

  1. https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html ↩
@reitermarkus reitermarkus added C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 23, 2024
@reitermarkus reitermarkus mentioned this issue Jan 24, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Jan 30, 2024
@GuillaumeGomez
Rollup merge of rust-lang#120295 - reitermarkus:remove-ffi-nonzero, r…
4f4ceef 
…=dtolnay

Remove `raw_os_nonzero` feature.

This feature is superseded by a generic `NonZero` type: rust-lang#120257

Closes rust-lang#82363.
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Jan 30, 2024
@rust-timer
Unrolled build for rust-lang#120295
615a32b 
Rollup merge of rust-lang#120295 - reitermarkus:remove-ffi-nonzero, r=dtolnay

Remove `raw_os_nonzero` feature.

This feature is superseded by a generic `NonZero` type: rust-lang#120257

Closes rust-lang#82363.
This was referenced Jan 30, 2024
Closed
Closed
@reitermarkus reitermarkus mentioned this issue Jan 30, 2024
Merged
@reitermarkus
Copy link
Contributor Author

@dtolnay, given the documentation issue, making NonZero::new and other constructors generic can really only be done during/after stabilization, so the only blocker I can see right now is stabilization itself. Can this enter FCP, or do we want to wait for #120486?

@dtolnay dtolnay added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Jan 31, 2024
@oli-obk oli-obk mentioned this issue Feb 1, 2024
Merged
@reitermarkus reitermarkus mentioned this issue Feb 1, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 3, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
4dc8ec8 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `@dtolnay`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 4, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
f1a744a 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ``@dtolnay``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
25ffdcc 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ```@dtolnay```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
5e7fb36 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ````@dtolnay````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 5, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
9b8f1a9 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `````@dtolnay`````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
0002b8c 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `@dtolnay`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 6, 2024
@matthiaskrgr
Rollup merge of rust-lang#120521 - reitermarkus:generic-nonzero-const…
3ad89af 
…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ``@dtolnay``
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 7, 2024
@bors
Auto merge of rust-lang#120521 - reitermarkus:generic-nonzero-constru…
7567c7c 
…ctors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `@dtolnay`
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 8, 2024
@bors
Auto merge of rust-lang#120521 - reitermarkus:generic-nonzero-constru…
384b02c 
…ctors, r=dtolnay

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `@dtolnay`
@reitermarkus reitermarkus mentioned this issue Feb 8, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120809 - reitermarkus:generic-nonzero-const…
222daa8 
…ructors, r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang#120257

See rust-lang#120521 (comment).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120809 - reitermarkus:generic-nonzero-const…
376640c 
…ructors, r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang#120257

See rust-lang#120521 (comment).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120809 - reitermarkus:generic-nonzero-const…
8ebe9f0 
…ructors, r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang#120257

See rust-lang#120521 (comment).
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Feb 9, 2024
@matthiaskrgr
Rollup merge of rust-lang#120809 - reitermarkus:generic-nonzero-const…
475c47a 
…ructors, r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang#120257

See rust-lang#120521 (comment).
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Feb 9, 2024
@rust-timer
Unrolled build for rust-lang#120809
1476217 
Rollup merge of rust-lang#120809 - reitermarkus:generic-nonzero-constructors, r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang#120257

See rust-lang#120521 (comment).
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Feb 10, 2024
@matthiaskrgr
Rollup merge of #120809 - reitermarkus:generic-nonzero-constructors, …
ba185c7 
…r=Nilstrieb

Use `transmute_unchecked` in `NonZero::new`.

Tracking issue: rust-lang/rust#120257

See rust-lang/rust#120521 (comment).
oli-obk added a commit to oli-obk/rust that referenced this issue Feb 13, 2024
@oli-obk
Rollup merge of rust-lang#120486 - reitermarkus:use-generic-nonzero, …
c28066a 
…r=dtolnay

Use generic `NonZero` internally.

Tracking issue: rust-lang#120257
oli-obk added a commit to oli-obk/rust that referenced this issue Feb 13, 2024
@oli-obk
Rollup merge of rust-lang#120563 - reitermarkus:generic-nonzero-get, …
10a5d53 
…r=dtolnay

Make `NonZero::get` generic.

Tracking issue: rust-lang#120257

Depends on rust-lang#120521.

r? `@dtolnay`
@reitermarkus
Copy link
Contributor Author

reitermarkus commented Apr 11, 2024 •
edited
Loading

the compiler should be able to create a zeroed bit pattern for any known type

The problem is not creating the bit pattern, it's ensuring that pattern is used as a niche, which currently can only be done with #[rustc_layout_scalar_valid_range_{start,end}], i.e. not in user code.

Furthermore, this would allow us to move this particular issue forward

Creating a user-implementable Zeroable trait is not part of this tracking issue, so this is not a blocker in any case.

@RalfJung
Copy link
Member

Indeed, any discussion of having user-defined NonZero types is off-topic in this tracking issue.

@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Apr 11, 2024
@rfcbot
Copy link
Collaborator

rfcbot commented Apr 11, 2024

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

@tmccombs
Copy link
Contributor

Indeed, any discussion of having user-defined NonZero types is off-topic in this tracking issue.

I probably should have been more clear, but the reason I brought it up is I'm not sure if it is merged as is, if it would be possible to change it to allow user-defined NonZero types in the future in a backwards compatible way.

@reitermarkus
Copy link
Contributor Author

if it would be possible to change it to allow user-defined NonZero types in the future in a backwards compatible way.

Yes, the ZeroablePrimitive trait is perma-unstable and sealed in order to avoid any compatibility issues.

@reitermarkus reitermarkus mentioned this issue Apr 21, 2024
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Apr 22, 2024
@GuillaumeGomez
Rollup merge of rust-lang#124230 - reitermarkus:generic-nonzero-stabl…
6a326d8 
…e, r=dtolnay

Stabilize generic `NonZero`.

Tracking issue: rust-lang#120257

r? `@dtolnay`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Apr 23, 2024
@rust-timer
Unrolled build for rust-lang#124230
167801b 
Rollup merge of rust-lang#124230 - reitermarkus:generic-nonzero-stable, r=dtolnay

Stabilize generic `NonZero`.

Tracking issue: rust-lang#120257

r? `@dtolnay`
@dtolnay dtolnay closed this as completed Apr 23, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Apr 23, 2024
@GuillaumeGomez
Rollup merge of #124230 - reitermarkus:generic-nonzero-stable, r=dtolnay
556e829 
Stabilize generic `NonZero`.

Tracking issue: rust-lang/rust#120257

r? `@dtolnay`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #120486 - reitermarkus:use-generic-nonzero, r=dtolnay
7a1e142 
Use generic `NonZero` internally.

Tracking issue: rust-lang/rust#120257
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #120563 - reitermarkus:generic-nonzero-get, r=dtolnay
9d527db 
Make `NonZero::get` generic.

Tracking issue: rust-lang/rust#120257

Depends on rust-lang/rust#120521.

r? `@dtolnay`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #121461 - reitermarkus:generic-nonzero-tests, r=dtolnay
3ec6284 
Use generic `NonZero` in tests.

Tracking issue: rust-lang/rust#120257

r? `@dtolnay`
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this issue Apr 27, 2024
@bors
Auto merge of #121885 - reitermarkus:generic-nonzero-inner, r=oli-obk…
c6b1f8b 
…,wesleywiser

Move generic `NonZero` `rustc_layout_scalar_valid_range_start` attribute to inner type.

Tracking issue: rust-lang/rust#120257

r? `@dtolnay`
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 29, 2024
@reitermarkus reitermarkus mentioned this issue May 1, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#124587 - reitermarkus:use-generic-nonzero, …
d174a49 
…r=dtolnay

Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang#120257

r? `@dtolnay`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue May 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#124587 - reitermarkus:use-generic-nonzero, …
d8a3a69 
…r=dtolnay

Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang#120257

r? ``@dtolnay``
rust-timer added a commit to rust-lang-ci/rust that referenced this issue May 8, 2024
@rust-timer
Unrolled build for rust-lang#124587
8487056 
Rollup merge of rust-lang#124587 - reitermarkus:use-generic-nonzero, r=dtolnay

Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang#120257

r? ``@dtolnay``
github-actions bot pushed a commit to rust-lang/miri that referenced this issue May 11, 2024
@matthiaskrgr
Rollup merge of #124587 - reitermarkus:use-generic-nonzero, r=dtolnay
b8806db 
Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang/rust#120257

r? ``@dtolnay``
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue May 16, 2024
@matthiaskrgr
Rollup merge of #124587 - reitermarkus:use-generic-nonzero, r=dtolnay
67a886b 
Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang/rust#120257

r? ``@dtolnay``
flip1995 pushed a commit to flip1995/rust-clippy that referenced this issue May 24, 2024
@matthiaskrgr
Rollup merge of #124587 - reitermarkus:use-generic-nonzero, r=dtolnay
1756ad7 
Generic `NonZero` post-stabilization changes.

Tracking issue: rust-lang/rust#120257

r? ``@dtolnay``
This was referenced Sep 16, 2024
Closed
Closed
workingjubilee added a commit to workingjubilee/rustc that referenced this issue Sep 19, 2024
@workingjubilee
Rollup merge of rust-lang#130543 - CAD97:generic-atomic, r=Noratrieb
8fab921 
Create `Atomic<T>` type alias

and use it in core/alloc/std where possible, ignoring test files for now.

This is step one, creating the alias from `Atomic<T>` to `AtomicT`. The next step of flipping this and aliasing `AtomicT` to `Atomic<T>` will have a bigger impact, since `AtomicT` imports can be dropped once `Atomic::new` is a usable name.

First commit is the true change. Second commit is mostly mechanical replacement of `AtomicT` type names with `Atomic<T>`.

See [how this was done for `NonZero`](rust-lang#120257) for the rough blueprint I'm following.

- ACP: rust-lang/libs-team#443 (comment)
- Tracking issue: rust-lang#130539
@dvdplm dvdplm mentioned this issue Oct 9, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue Feb 6, 2025
@bors
Auto merge of rust-lang#130543 - CAD97:generic-atomic, r=Noratrieb
7c80d00 
Create `Atomic<T>` type alias

and use it in core/alloc/std where possible, ignoring test files for now.

This is step one, creating the alias from `Atomic<T>` to `AtomicT`. The next step of flipping this and aliasing `AtomicT` to `Atomic<T>` will have a bigger impact, since `AtomicT` imports can be dropped once `Atomic::new` is a usable name.

First commit is the true change. Second commit is mostly mechanical replacement of `AtomicT` type names with `Atomic<T>`.

See [how this was done for `NonZero`](rust-lang#120257) for the rough blueprint I'm following.

- ACP: rust-lang/libs-team#443 (comment)
- Tracking issue: rust-lang#130539
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests