Skip to content

Add private NonZero<T> type alias. #119990

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

reitermarkus
Copy link
Contributor

According to step 2 suggested in #100428 (review).

This adds a private type alias for NonZero<T> so that some parts of the code can already start using NonZero<T> syntax.

Using NonZero<T> for convert and other parts which implement From doesn't work while it is a type alias, since this results in conflicting implementations.

@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2024

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 15, 2024
@reitermarkus
Copy link
Contributor Author

r? @dtolnay

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dtolnay
Copy link
Member

dtolnay commented Jan 15, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

📌 Commit f760223 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2024
@dtolnay
Copy link
Member

dtolnay commented Jan 15, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 15, 2024

📌 Commit 604d208 has been approved by dtolnay

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#118361 (stabilise bound_map)
 - rust-lang#119816 (Define hidden types in confirmation)
 - rust-lang#119900 (Inline `check_closure`, simplify `deduce_sig_from_projection`)
 - rust-lang#119969 (Simplify `closure_env_ty` and `closure_env_param`)
 - rust-lang#119990 (Add private `NonZero<T>` type alias.)
 - rust-lang#119998 (Update books)
 - rust-lang#120002 (Lint `overlapping_ranges_endpoints` directly instead of collecting into a Vec)
 - rust-lang#120018 (Don't allow `.html` files in `tests/mir-opt/`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ac3108f into rust-lang:master Jan 16, 2024
@rustbot rustbot added this to the 1.77.0 milestone Jan 16, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 16, 2024
Rollup merge of rust-lang#119990 - reitermarkus:nonzero-type-alias, r=dtolnay

Add private `NonZero<T>` type alias.

According to step 2 suggested in rust-lang#100428 (review).

This adds a private type alias for `NonZero<T>` so that some parts of the code can already start using `NonZero<T>` syntax.

Using `NonZero<T>` for `convert` and other parts which implement `From` doesn't work while it is a type alias, since this results in conflicting implementations.
@reitermarkus reitermarkus deleted the nonzero-type-alias branch January 17, 2024 11:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants