Skip to content

Update language item from share to sync #16988

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
mdinger opened this issue Sep 4, 2014 · 4 comments
Closed

Update language item from share to sync #16988

mdinger opened this issue Sep 4, 2014 · 4 comments
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@mdinger
Copy link
Contributor

mdinger commented Sep 4, 2014

PR #16285 missed changing the language item from no_share_bound to no_sync_bound. PR #16780 made the manual consistent with the current language items. Everything must now be updated to sync.

The language item and the manual. The current language item:

// Variant name, Name, Method name;
...
NoSyncItem, "no_share_bound", no_share_bound;
@brson
Copy link
Contributor

brson commented Sep 4, 2014

Good first bug.

@gamazeps
Copy link
Contributor

gamazeps commented Sep 4, 2014

I have very few experience on rust but I'll try if your ok with this ;)

@mdinger
Copy link
Contributor Author

mdinger commented Sep 4, 2014

FYI, I tried to fix it at #16780 (comment) but started getting warnings. I couldn't find anything else to change with grep (I figured it should just be a name swap). 30-45 min compile times made this annoying when I didn't know what was wrong...

bors added a commit that referenced this issue Sep 6, 2014
Changed the names according to the issue #16988
bors added a commit that referenced this issue Sep 6, 2014
Changed the names according to the issue #16988
@mdinger
Copy link
Contributor Author

mdinger commented Sep 8, 2014

Should be fixed.

@mdinger mdinger closed this as completed Sep 8, 2014
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 7, 2024
lnicola pushed a commit to lnicola/rust that referenced this issue Apr 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

No branches or pull requests

3 participants